Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add tooltip help text for Transform filter query control #108720

Merged
merged 6 commits into from
Aug 19, 2021

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Aug 16, 2021

Summary

This PR addresses #102610. Currently, Transform already supports the range filter for numeric or date time field. However, to make it clear that Transform can also support more complex aggregation use cases beyond the UI controls, this PR adds additional help text to direct usage towards the JSON editor if needed.

Screen Shot 2021-08-16 at 10 29 20

Checklist

Delete any items that are not applicable to this PR.

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM, thanks!

@qn895
Copy link
Member Author

qn895 commented Aug 17, 2021

@elasticmachine merge upstream

@qn895
Copy link
Member Author

qn895 commented Aug 17, 2021

@elasticmachine merge upstream

@qn895 qn895 added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 17, 2021
@mistic mistic added v7.16.0 and removed v7.15.0 labels Aug 18, 2021
@qn895
Copy link
Member Author

qn895 commented Aug 19, 2021

@elasticmachine merge upstream

@qn895 qn895 enabled auto-merge (squash) August 19, 2021 03:12
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 917.9KB 918.5KB +636.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 merged commit 4d0623e into elastic:master Aug 19, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 19, 2021
…c#108720)

* [ML] Add tooltip help text

* [ML] Remove unused import

* [ML] Update tooltip content to be clearer

Co-authored-by: Lisa Cawley <[email protected]>

Co-authored-by: Lisa Cawley <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 19, 2021
… (#109195)

* [ML] Add tooltip help text

* [ML] Remove unused import

* [ML] Update tooltip content to be clearer

Co-authored-by: Lisa Cawley <[email protected]>

Co-authored-by: Lisa Cawley <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Quynh Nguyen <[email protected]>
Co-authored-by: Lisa Cawley <[email protected]>
@qn895 qn895 deleted the ml-transform-range-filter-editor branch September 21, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Transforms ML transforms :ml release_note:enhancement v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants