[APM] Refactor Cypress e2e tests #109024
Merged
[APM] Refactor Cypress e2e tests #109024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sorenlouv
commented
Aug 18, 2021
•
sorenlouv
commented
- Update documentation and some naming
- Only run archives once before starting tests (instead of before every test)
sorenlouv
added
release_note:skip
smith
reviewed
Aug 18, 2021
|
@sqren I see that the deep_links tests are failing here too, could you skip them for now? |
sorenlouv
changed the title
sorenlouv
force-pushed
the
update-security-script
branch
from
8049f83
to
62bdca3
Compare
Co-authored-by: Nathan L Smith <[email protected]>
sorenlouv
commented
Aug 19, 2021
| @@ -33,6 +33,7 @@ async function config({ readConfigFile }: FtrConfigProviderContext) { | |||
| ...xpackFunctionalTestsConfig.get('kbnTestServer'), | |||
| serverArgs: [ | |||
| ...xpackFunctionalTestsConfig.get('kbnTestServer.serverArgs'), | |||
| '--home.disableWelcomeScreen=true', | |||
There was a problem hiding this comment.
This was causing the initial test to fail
sorenlouv
commented
Aug 19, 2021
| // 'No items found' | ||
| // ); | ||
| // }); | ||
| // }); |
There was a problem hiding this comment.
I've disabled testing the empty states for now. We can discuss what a good setup would be for running tests with different data requirements
|
jenkins run the e2e |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
sorenlouv
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 19, 2021
* Improve script to setup users and roles * fix readme * CI fixes * add index permissions to roles * disable welcome screen * Run es archive once before tests * Fix ts issues * Update x-pack/plugins/apm/readme.md Co-authored-by: Nathan L Smith <[email protected]> Co-authored-by: Nathan L Smith <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 19, 2021
* Improve script to setup users and roles * fix readme * CI fixes * add index permissions to roles * disable welcome screen * Run es archive once before tests * Fix ts issues * Update x-pack/plugins/apm/readme.md Co-authored-by: Nathan L Smith <[email protected]> Co-authored-by: Nathan L Smith <[email protected]> Co-authored-by: Søren Louv-Jansen <[email protected]> Co-authored-by: Nathan L Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.