Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Graph] Rename Index pattern to Data view #110403

Merged
merged 6 commits into from
Oct 8, 2021
Merged

[Graph] Rename Index pattern to Data view #110403

merged 6 commits into from
Oct 8, 2021

Conversation

DianaDerevyankina
Copy link
Contributor

@DianaDerevyankina DianaDerevyankina commented Aug 27, 2021 •
edited by stratoula
Loading

Part of #114083

Summary

Renamed index patterns to data views in Graph UI.

image

image

image

Checklist

For maintainers

@DianaDerevyankina DianaDerevyankina added Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Aug 27, 2021
@DianaDerevyankina DianaDerevyankina self-assigned this Aug 27, 2021
@DianaDerevyankina DianaDerevyankina added backport:skip This commit does not require backporting and removed v7.16.0 labels Sep 29, 2021
@DianaDerevyankina
Merge branch 'master' into graph-index-pattern-to-data-view
a81b7e0 
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
VladLasitsa
VladLasitsa approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

timductive
timductive reviewed Sep 30, 2021
View reviewed changes
x-pack/plugins/graph/public/components/guidance_panel/guidance_panel.tsx Outdated
@@ -173,13 +173,13 @@ function GuidancePanelComponent(props: GuidancePanelProps) {
<p>
<FormattedMessage
id="xpack.graph.noDataSourceNotificationMessageText"
defaultMessage="No data sources found. Go to {managementIndexPatternsLink} and create an index pattern for your Elasticsearch indices."
defaultMessage="No data sources found. Go to {managementIndexPatternsLink} and create an data view for your Elasticsearch indices."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small grammar fix
"and create a data view"

@DianaDerevyankina
Copy link
Contributor Author

@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review October 6, 2021 10:53
@stratoula stratoula requested a review from a team as a code owner October 6, 2021 10:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@DianaDerevyankina
Copy link
Contributor Author

@elasticmachine merge upstream

dej611
dej611 approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome 👍

@DianaDerevyankina
Copy link
Contributor Author

@elasticmachine merge upstream

timroes
timroes approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Please don't merge yet. We're still waiting on some clarification on branches. cc @stratoula

@DianaDerevyankina DianaDerevyankina changed the base branch from master to index_patterns_to_data_views_user_content_feature_branch October 7, 2021 13:24
@DianaDerevyankina DianaDerevyankina requested a review from a team as a code owner October 7, 2021 13:24
@DianaDerevyankina DianaDerevyankina removed request for a team October 7, 2021 14:08
@DianaDerevyankina DianaDerevyankina removed Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability Team:Fleet Team label for Observability Data Collection Fleet team labels Oct 7, 2021
@elastic elastic deleted a comment from elasticmachine Oct 7, 2021
@elastic elastic deleted a comment from elasticmachine Oct 7, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@DianaDerevyankina DianaDerevyankina merged commit f21d74e into elastic:index_patterns_to_data_views_user_content_feature_branch Oct 8, 2021
@DianaDerevyankina DianaDerevyankina mentioned this pull request Oct 12, 2021
Closed
@bhavyarm bhavyarm mentioned this pull request Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timductive timductive timductive left review comments

@timroes timroes timroes approved these changes

@dej611 dej611 dej611 approved these changes

@VladLasitsa VladLasitsa VladLasitsa approved these changes

@alexwizp alexwizp alexwizp approved these changes

@stratoula stratoula Awaiting requested review from stratoula

@mbondyra mbondyra Awaiting requested review from mbondyra

Assignees

@DianaDerevyankina DianaDerevyankina

Labels
backport:skip This commit does not require backporting Feature:Graph Graph application feature release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@DianaDerevyankina @elasticmachine @kibanamachine @timroes @dej611 @timductive @VladLasitsa @alexwizp