Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make saved queries share-capable #111462

Merged
merged 11 commits into from
Sep 14, 2021
Merged

Make saved queries share-capable #111462

merged 11 commits into from
Sep 14, 2021

Conversation

lukasolson
Copy link
Member

Summary

Relies on #111229.

Updates the saved query saved object type to be share capable. This needs to be done in a separate step than #111229 because it can't be backported.

@lukasolson lukasolson added v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes labels Sep 7, 2021
@lukasolson lukasolson self-assigned this Sep 7, 2021
@lukasolson lukasolson requested a review from a team as a code owner September 7, 2021 20:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

jportner
jportner reviewed Sep 7, 2021
View reviewed changes
src/plugins/data/server/saved_objects/query.ts
Comment on lines -14 to +15
namespaceType: 'single',
namespaceType: 'multiple-isolated',
convertToMultiNamespaceTypeVersion: '8.0.0',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you accidentally included all of the other changes that are in the other PR, too.

This PR should only need these changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I did this so I don't forget to merge the other PR first before merging this one

tsullivan
tsullivan approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - reviewed the code

@lukasolson lukasolson enabled auto-merge (squash) September 13, 2021 23:02
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

@lukasolson lukasolson merged commit fbeefed into elastic:master Sep 14, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 16, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 111462 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 111462 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 111462 or prevent reminders by adding the backport:skip label.

@jportner jportner added the backport:skip This commit does not require backporting label Sep 20, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 20, 2021
@lukasolson lukasolson mentioned this pull request Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner left review comments

@tsullivan tsullivan tsullivan approved these changes

Assignees

@lukasolson lukasolson

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukasolson @elasticmachine @kibanamachine @tsullivan @jportner