Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Added logger info and restructuring some mounter tests #111953

Merged
merged 2 commits into from
Sep 13, 2021
Merged

[Lens] Added logger info and restructuring some mounter tests #111953

merged 2 commits into from
Sep 13, 2021

Conversation

mbondyra
Copy link
Contributor

Summary

Adding an extra information about Lens state logger:

Lens state is kept in the Redux Store. To enable redux logger, open Chrome Developer Tools and type in the console: `window.ELASTIC_LENS_LOGGER=true`.

Also adding a test for load_initial middleware.

@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 13, 2021
@mbondyra mbondyra requested a review from a team as a code owner September 13, 2021 13:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

stratoula
stratoula approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, LGTM :)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra merged commit cae5bdc into elastic:master Sep 13, 2021
@mbondyra mbondyra deleted the lens/add_tests_to_store branch September 13, 2021 21:12
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 13, 2021
@mbondyra @kibanamachine
[Lens] Added logger info and restructuring some mounter tests (elasti…
f1a6b9e 
…c#111953)

* [Lens] added logger info and restructuring some mounter tests

* snapshot updated
@kibanamachine kibanamachine mentioned this pull request Sep 13, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 13, 2021
@kibanamachine @mbondyra
[Lens] Added logger info and restructuring some mounter tests (#111953)…
b16e312 
… (#112028)

* [Lens] added logger info and restructuring some mounter tests

* snapshot updated

Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbondyra @elasticmachine @kibanamachine @stratoula