Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Change terminology: "index pattern" becomes "data view" #112021

Closed
wants to merge 13 commits into from
Closed

[APM] Change terminology: "index pattern" becomes "data view" #112021

wants to merge 13 commits into from

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Sep 13, 2021 •
edited
Loading

closes #101206

Renames all texts, files and function from index pattern to data view

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 13, 2021
@cauemarcondes cauemarcondes changed the title Apm index pattern to data view [APM] Change terminology: "index pattern" becomes "data view" Sep 14, 2021
cauemarcondes
cauemarcondes commented Sep 14, 2021
View reviewed changes
x-pack/plugins/apm/e2e/ci/kibana.e2e.yml
@@ -11,7 +11,7 @@ elasticsearch.hosts: http://localhost:9201
elasticsearch.username: 'kibana_system_user'
elasticsearch.password: 'changeme'

# APM index pattern
# APM data view
apm_oss.indexPattern: apm-*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sqren Should I also change the config key to dataView?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been deprecated so you can just leave that: #111133

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw. weren't you going to remove the entire e2e folder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will, but in another PR.

cauemarcondes
cauemarcondes commented Sep 14, 2021
View reviewed changes
x-pack/plugins/apm/server/routes/data_view.ts
const staticIndexPatternRoute = createApmServerRoute({
endpoint: 'POST /api/apm/index_pattern/static',
const staticDataViewRoute = createApmServerRoute({
endpoint: 'POST /api/apm/data_view/static',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sqren Should I change the APIs to data_view too?

@cauemarcondes cauemarcondes marked this pull request as ready for review September 14, 2021 15:02
@cauemarcondes cauemarcondes requested review from a team as code owners September 14, 2021 15:02
shahzad31
shahzad31 approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for Uptime changes LGTM,

WFG !!

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Sep 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes
Copy link
Contributor Author

Thanks for Uptime changes LGTM,

WFG !!

@shahzad31 There're still a few components that use Index pattern as property, do you want me to change it as well?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.4MB 4.4MB -259.0B
Unknown metric groups

References to deprecated APIs

id before after diff
apm 57 37 -20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv
Copy link
Member

fyi @mattkime

@sorenlouv
Copy link
Member

Can you create this PR against the existing feature branch:

index_patterns_to_data_views_user_content_feature_branch (#109821)

for context see #100844

@cauemarcondes
Copy link
Contributor Author

New PR pointing to the feature branch #112166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv left review comments

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Change terminology: "index pattern" becomes "data view"
5 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv @shahzad31