Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SavedObjectsClient.bulkResolve #112025

Merged
merged 10 commits into from
Sep 16, 2021
Merged

Add SavedObjectsClient.bulkResolve #112025

merged 10 commits into from
Sep 16, 2021

Commits on Sep 14, 2021

  1. Refactor some internal utils out of the SOR

    @jportner
    jportner committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    0b6fc98 View commit details
    Browse the repository at this point in the history

  2. Add internalBulkResolve module 

    In abstracting this out to a separate module, I was able to reuse
this instead of the existing resolve code, and I was able to
simplify the unit tests.
Note, there is currently an inconsistent API response between
get and bulkGet (an unsupported type for the former returns 404,
and the latter returns 400). I opted to return a 400 for
bulkResolveInternal as that is the most consistent response, so
that means I had to change the integration tests for resolve
accordingly.
    @jportner
    jportner committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    1e61891 View commit details
    Browse the repository at this point in the history

  3. Fix jest integration tests

    @jportner
    jportner committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    9a85fc9 View commit details
    Browse the repository at this point in the history

  4. Add bulkResolve API

    @jportner
    jportner committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    cc26c0a View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Merge branch 'master' into issue-111201-add-bulkresolve

    @jportner
    jportner committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    244022b View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Abstract out discriminated union types and type guards

    @jportner
    jportner committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    bbea46f View commit details
    Browse the repository at this point in the history

  2. Remove redundant TSDocs from spaces SOC wrapper

    @jportner
    jportner committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    6579f70 View commit details
    Browse the repository at this point in the history

  3. Address remaining review feedback

    @jportner
    jportner committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    f09ae54 View commit details
    Browse the repository at this point in the history

  4. Update docs

    @jportner
    jportner committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    d09765c View commit details
    Browse the repository at this point in the history

  5. Update sharing saved objects dev docs 

    Unrelated to this PR but I noticed that this needed to be changed.
    @jportner
    jportner committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    db3aee5 View commit details
    Browse the repository at this point in the history