[Workplace Search] Use the correct naming: organizational source, personal dashboard, private source #112426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakhinvadim
changed the title
yakhinvadim
added
auto-backport
scottybollinger
approved these changes
Sep 16, 2021
..._search/public/applications/workplace_search/views/groups/components/group_manager_modal.tsx
Outdated
Show resolved
Hide resolved
...public/applications/workplace_search/views/groups/components/group_source_prioritization.tsx
Show resolved
Hide resolved
…_search/views/groups/components/group_manager_modal.tsx Co-authored-by: Scotty Bollinger <[email protected]>
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 16, 2021
…sonal dashboard, private source (elastic#112426) * Rename shared sources -> organizational sources on Overview page * Rename shared sources -> organizational sources in groups * Rename shared sources -> organizational sources on Sources pages * Rename shared sources -> organizational sources in filenames and imports * Rename private dashboard to personal dashboard * Rename PERSONAL_SOURCES_PATH -> PRIVATE_SOURCES_PATH * Rename personalSourcesCount -> privateSourcesCount * Rename canCreatePersonalSources -> canCreatePrivateSources * Rename the remaining personal_source -> private_source * Autofix i18n * Update x-pack/plugins/enterprise_search/public/applications/workplace_search/views/groups/components/group_manager_modal.tsx Co-authored-by: Scotty Bollinger <[email protected]> Co-authored-by: Scotty Bollinger <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 16, 2021
…sonal dashboard, private source (#112426) (#112482) * Rename shared sources -> organizational sources on Overview page * Rename shared sources -> organizational sources in groups * Rename shared sources -> organizational sources on Sources pages * Rename shared sources -> organizational sources in filenames and imports * Rename private dashboard to personal dashboard * Rename PERSONAL_SOURCES_PATH -> PRIVATE_SOURCES_PATH * Rename personalSourcesCount -> privateSourcesCount * Rename canCreatePersonalSources -> canCreatePrivateSources * Rename the remaining personal_source -> private_source * Autofix i18n * Update x-pack/plugins/enterprise_search/public/applications/workplace_search/views/groups/components/group_manager_modal.tsx Co-authored-by: Scotty Bollinger <[email protected]> Co-authored-by: Scotty Bollinger <[email protected]> Co-authored-by: Vadim Yakhin <[email protected]> Co-authored-by: Scotty Bollinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames several things in the Workplace Search codebase:
Enterprise Search needs to be run with these changes included https://github.com/elastic/ent-search/pull/4670 for this PR to work.
Many changes only touched variable names, but here are some screenshots with the UI changes:
Checklist