-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor a11y tests to group by data sets #113876
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream Unrelated Jest test failure: console.log
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/certificates·ts.Uptime app with generated data certificates with certs page "before each" hook for "displays certificates"Standard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @LeeDr for doing this!
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
* test if 2s sleep fixes flakey test * switch from sleep to retry.waitFor * remove .only, add comments to config file about sample data add/remove * refactor a11y tests for sample data load * refactor a11y tests for sample data load * cleanup comments * cleanup comments * fix eslint errors Co-authored-by: Kibana Machine <[email protected]>
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
* test if 2s sleep fixes flakey test * switch from sleep to retry.waitFor * remove .only, add comments to config file about sample data add/remove * refactor a11y tests for sample data load * refactor a11y tests for sample data load * cleanup comments * cleanup comments * fix eslint errors Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Lee Drengenberg <[email protected]>
Summary
Most of the a11y tests use sample flights data set. But most of them navigated to '/tutorial_directory/sampleData' and at least checked that the data was installed. And only one of them was removing the data. So I created an index file and moved the sample data loading to a before method there. 3 tests either use no data, or load different data and they're in a separate describe block.
Checklist
Delete any items that are not applicable to this PR.