Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data Visualizer: index pattern to data view in user facing copy #114258

Conversation

peteharverson
Copy link
Contributor

Summary

Part of #108048, replaces the use of 'index pattern' with 'data view' in user facing labels in the data_visualizer plugin.

Only address visible text in the UI, plus a few related uses of 'index pattern' in comments, functional test descriptions and REST API URI query parameter.

Note that this PR merges into the index_patterns_to_data_views_user_content_feature_branch feature branch, as per instructions in the meta-issue

@peteharverson peteharverson added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:File and Index Data Viz ML file and index data visualizer labels Oct 7, 2021
@peteharverson peteharverson self-assigned this Oct 7, 2021
@peteharverson peteharverson requested a review from a team as a code owner October 7, 2021 11:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

@qn895
Copy link
Member

qn895 commented Oct 7, 2021

Tested and LGTM 🎉

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@peteharverson peteharverson merged commit bf69e10 into elastic:index_patterns_to_data_views_user_content_feature_branch Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants