Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] avoid multiple requests updating page data #115999

Merged
merged 2 commits into from
Oct 22, 2021
Merged

[Stack Monitoring] avoid multiple requests updating page data #115999

merged 2 commits into from
Oct 22, 2021

Conversation

neptunian
Copy link
Contributor

@neptunian neptunian commented Oct 21, 2021 •
edited
Loading

Summary

Resolves #111536
Reimplements #27253

#27253 was implemented because sometimes the requests for page data takes longer than the time interval. We want to not make a request if the current one is still pending.

Test

  • Navigate to a stack monitoring app first
  • Open dev tools and throttle your network to slow 3g so requests are slow to respond
  • Set the interval to something very short like .5 seconds
    Screen Shot 2021-10-21 at 2 22 18 PM
  • Look in the network tab that requests are not being made every .5 seconds or in parallel but as fast as they're able to return a response

@neptunian neptunian added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 Epic: Stack Monitoring de-angularization labels Oct 21, 2021
@neptunian neptunian self-assigned this Oct 21, 2021
@neptunian neptunian added the release_note:skip Skip the PR/issue when compiling release notes label Oct 21, 2021
@neptunian neptunian marked this pull request as ready for review October 21, 2021 19:29
@neptunian neptunian requested a review from a team as a code owner October 21, 2021 19:29
@neptunian neptunian requested review from a team October 21, 2021 19:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

phillipb
phillipb approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brillant!

@neptunian
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #11 / detection engine api security and spaces enabled Rule exception operators for endpoints "is" operator should filter 1 value set as an endpoint exception and 1 value set as a normal rule exception

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 486.3KB 486.4KB +75.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@neptunian neptunian added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 22, 2021
@neptunian neptunian merged commit 003c0f3 into elastic:master Oct 22, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 22, 2021
@neptunian @kibanamachine
don't request when request is pending (elastic#115999)
09166e8 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Oct 22, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.16

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 22, 2021
@kibanamachine @neptunian
don't request when request is pending (#115999) (#116046)
589302e 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Sandra G <[email protected]>
shivindera pushed a commit to shivindera/kibana that referenced this pull request Oct 25, 2021
@neptunian @kibanamachine @shivindera
don't request when request is pending (elastic#115999)
f331dc5 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipb phillipb phillipb approved these changes

Assignees

@neptunian neptunian

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Epic: Stack Monitoring de-angularization release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] [Angular Removal] Avoid multiple requests simulataneously
4 participants
@neptunian @elasticmachine @kibanamachine @phillipb