Push panel rendering logic out of dashboard #11618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
force-pushed
the
Refactor-render-logic
branch
2 times, most recently
from
2b01d1f
to
f0a5cd3
Compare
stacey-gammon
force-pushed
the
Refactor-render-logic
branch
2 times, most recently
from
a25cb06
to
8c01181
Compare
|
@spalger no rush on this PR, just wanted to get your opinion since the goal is to move towards a pluggable dashboard panel system and want to see what you think of this initial approach. |
|
Actually, hold off on review. I'm going to sync with @thomasneirynck on the visualization plugin work they are doing. Perhaps the right move is to make saved searches a visualization plugin, and then we can focus on a single "panel"/"visualization" plugin system instead of two. As it is now, the difference between a panel plugin and a visualization plugin is very vague. cc @nreese |
|
Blocked on discussions with the visualization team on the best way to move forward with combined efforts. |
stacey-gammon
force-pushed
the
Refactor-render-logic
branch
2 times, most recently
from
2c12baf
to
5d0f365
Compare
Let external plugins register panel renderer providers keep loadedPanel promise on the scope for tests Not great to keep this around only for tests, but it follows the previous logic. Fix tests that expect the panel-content div to be the old style Communicate panel title from renderer. Fix tests with extra request Theres an extra request in there because of the getTitle function. Our tests assumed one, this makes it handle any number of requests in them mget (assuming the mock response for each one is sufficient).
stacey-gammon
force-pushed
the
Refactor-render-logic
branch
from
5d0f365
to
70f1827
Compare
|
Closed in favor of #12146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paving the way for allowing plugins to register custom panel renderers by extracting rendering logic outside of Dashboard and creating a new registry.
Follow up steps to further improve the separation of logic:
broadcast:visSaved object not founddisplay error logic to the renderers