Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more robust way of entering color value #116566

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

flash1293
Copy link
Contributor

Fixes #115529

Some react components don't work well if clearing the input and entering the new value is happening too quickly - this is switching to a more robust approach closer to what a user would do. We had similar cases in other areas before.

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.1.0 labels Oct 28, 2021
@flash1293 flash1293 marked this pull request as ready for review October 28, 2021 15:54
@flash1293 flash1293 requested a review from a team as a code owner October 28, 2021 15:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, this indeed has solved past flakiness so I think it will stabilize this test suite!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 🆗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0 v8.1.0
Projects
None yet
5 participants