Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Implement KibanaThemeProvider #118965

Conversation

justinkambic
Copy link
Contributor

@justinkambic justinkambic commented Nov 17, 2021

Summary

Resolves #118954.

Part of #118866.

Adds KibanaThemeProvider implementation and provides theme$ prop to toMountPoint calls.

Checklist

Delete any items that are not applicable to this PR.

  • This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

For maintainers

@justinkambic justinkambic added chore v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Nov 17, 2021
@justinkambic justinkambic self-assigned this Nov 17, 2021
@justinkambic justinkambic removed v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Nov 17, 2021
@justinkambic justinkambic marked this pull request as ready for review November 18, 2021 14:59
@justinkambic justinkambic requested a review from a team as a code owner November 18, 2021 14:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 574.2KB 574.6KB +398.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@justinkambic justinkambic merged commit 28e8646 into elastic:main Nov 24, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 24, 2021
@justinkambic justinkambic deleted the 118954/add-new-kibana-theme-provider-to-uptime-app branch November 24, 2021 15:51
vitaliidm pushed a commit to vitaliidm/kibana that referenced this pull request Nov 25, 2021
…emeProvider` to uptime application. (elastic#118965)

Co-authored-by: Kibana Machine <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
…emeProvider` to uptime application. (elastic#118965)

Co-authored-by: Kibana Machine <[email protected]>
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
…emeProvider` to uptime application. (elastic#118965)

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime] Use new KibanaThemeProvider
5 participants