[Maps] Use theme provider in Maps-app

[thomasneirynck]

Part of #118875

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[nreese]

What about map_embeddable? Is KibanaThemeProvider needed there as well?

[thomasneirynck]

@nreese wrt #119060 (review)

What about map_embeddable? Is KibanaThemeProvider needed there as well?

I think not, because the embeddable will be inside the tree of other Kibana apps, and presumably we don't want duplicated nesting of this. This is an assumption only though. @pgayvallet is that correct?

[pgayvallet]

What about map_embeddable? Is KibanaThemeProvider needed there as well?

Given that map_embeddable uses it's own ReactDOM.render, it will need to be wrapper too, as it's a distinct react tree (yea, implementing 'global' providers in our architecture is a pain...).

Note that ideally, the theme$ passed down to MapEmbeddable would be provided by the 'owning' app though, as it would make more sense that have it provided internally by the embeddable plugin, but we can live without it for now if that's too complex.

[nreese]

With respect to #118866 (comment), looks like there are 4 places with Theme provider is required in maps plugin

[thomasneirynck]

@pgayvallet

wrt #119060 (comment)

If the "owning-app" needs to inject the $theme, I'd prefer splitting up this PR in different ones. There are quite a few "owning"-plugins that embed maps, all of them requiring different reviewing teams.

• Dashboard
• APM rum dashboards
• SIEM
• Canvas
• Tilemap legacy wrapper
• Regionmap legacy wrapper
• ML data visualizer
• ML anomaly explorer

For sanity, it might be easier to address them one-by-one (or, at least, in groups that make sense).

A parallel question: can we wrap the dom-trees with the kb-theme-provider without configuring the $theme-variable?

[thomasneirynck]

@elasticmachine merge upstream

[nreese]

LGTM - discussed that this is part of the fix and does not provide theme in all required locations
code review

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 02d9b82
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
maps	2.6MB	2.6MB	+59.0B

History

• 💚 Build #7742 succeeded 35bdd1d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[pgayvallet]

A parallel question: can we wrap the dom-trees with the kb-theme-provider without configuring the $theme-variable?

Sorry, missed that one. It wouldn't make much sense, given that we wouldn't be propagating the required variables to the EUI theme provider.