Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add theme provider to VisEditors react roots #119298

Merged
merged 12 commits into from
Nov 24, 2021
Merged

Add theme provider to VisEditors react roots #119298

merged 12 commits into from
Nov 24, 2021

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Nov 22, 2021 •
edited
Loading

Part of #118866

Adds the theme provider to all 38 react roots maintained by the VisEditors team (+ 3 instances of toMountPoint)

@flash1293 flash1293 added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0 labels Nov 22, 2021
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293 flash1293 mentioned this pull request Nov 23, 2021
Closed
@flash1293 flash1293 marked this pull request as ready for review November 23, 2021 10:16
@flash1293 flash1293 requested a review from a team as a code owner November 23, 2021 10:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula
Copy link
Contributor

@elasticmachine merge upstream

stratoula
stratoula approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! This looks great Joe! Thanx for applying the changes in all these plugins ❤️

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visDefaultEditor 122 123 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 872.2KB 872.4KB +123.0B
expressionMetricVis 8.3KB 8.3KB +1.0B
expressionTagcloud 7.6KB 7.6KB +7.0B
lens 966.8KB 968.2KB +1.4KB
visTypeTimelion 88.0KB 88.0KB -3.0B
visTypeVislib 359.3KB 359.3KB +78.0B
visualizations 59.1KB 59.2KB +75.0B
visualize 49.7KB 49.9KB +183.0B
total +1.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionMetricVis 6.6KB 6.8KB +218.0B
expressionTagcloud 7.2KB 7.5KB +226.0B
lens 44.2KB 44.2KB +30.0B
visDefaultEditor 19.0KB 19.3KB +277.0B
visTypePie 13.7KB 13.9KB +236.0B
visTypeTable 14.8KB 14.9KB +69.0B
visTypeTimelion 10.4KB 10.5KB +77.0B
visTypeTimeseries 14.5KB 14.6KB +168.0B
visTypeVega 37.2KB 37.2KB +66.0B
visTypeVislib 19.7KB 20.1KB +358.0B
visTypeXy 39.9KB 40.1KB +228.0B
visualizations 35.2KB 35.6KB +416.0B
total +2.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 69d0d78 into elastic:main Nov 24, 2021
vitaliidm pushed a commit to vitaliidm/kibana that referenced this pull request Nov 25, 2021
@flash1293 @vitaliidm
Add theme provider to VisEditors react roots (elastic#119298)
54db938
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@flash1293 @dmlemeshko
Add theme provider to VisEditors react roots (#119298)
9672718
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@flash1293 @TinLe
Add theme provider to VisEditors react roots (elastic#119298)
724d16b
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
@flash1293 @gbamparop
Add theme provider to VisEditors react roots (elastic#119298)
a2e717f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flash1293 @elasticmachine @stratoula @kibana-ci @kibanamachine