Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability] Passes theme$ to toMountPoint #120968

Merged
merged 9 commits into from
Dec 14, 2021
Merged

[Observability] Passes theme$ to toMountPoint #120968

merged 9 commits into from
Dec 14, 2021

Conversation

claudiopro
Copy link
Contributor

@claudiopro claudiopro commented Dec 9, 2021 •
edited by matschaffer
Loading

Summary

This PR adds options containing the value of theme$ as second argument of toMountPoint, passing it down from AppMountParams. It is the continuation of work initiated with #120400.

Closes #120896
Rel #118906

Checklist

@claudiopro claudiopro requested review from a team as code owners December 9, 2021 16:56
@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Dec 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@claudiopro claudiopro added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.1.0 labels Dec 9, 2021
sorenlouv
sorenlouv approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apm changes lgtm

@estermv estermv mentioned this pull request Dec 13, 2021
Closed
@claudiopro claudiopro requested a review from a team as a code owner December 13, 2021 16:59
@claudiopro claudiopro changed the title [Observability] Passes theme$ to toRenderMount [Observability] Passes theme$ to toMountPoint Dec 13, 2021
phillipb
phillipb approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra changes look good.

@matschaffer
Copy link
Contributor

Pretty sure this covers #120713 so I'll close that in favor of this one. Thanks!

@matschaffer
Copy link
Contributor

matschaffer commented Dec 14, 2021 •
edited
Loading

Ah, looks like this still might be missing the toMountPoint call sites mentioned in #120713 (review)

TBH I'm still pretty confused by all this, but I guess let's land this PR then we can do a follow up to figure out what to do about getting the theme down to the toasts as well.

@matschaffer matschaffer mentioned this pull request Dec 14, 2021
Merged
@matschaffer matschaffer enabled auto-merge (squash) December 14, 2021 14:57
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.0MB 3.0MB +34.0B
infra 988.6KB 988.7KB +60.0B
monitoring 445.5KB 445.6KB +36.0B
observability 362.1KB 362.2KB +112.0B
uptime 681.4KB 681.4KB +16.0B
total +258.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 62.3KB 62.3KB +36.0B
observability 77.6KB 77.6KB +18.0B
total +54.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

awahab07
awahab07 approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for uptime plugin.

@matschaffer matschaffer merged commit 4155142 into elastic:main Dec 14, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 14, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 120968

@claudiopro claudiopro mentioned this pull request Dec 14, 2021
Closed
@matschaffer
Copy link
Contributor

matschaffer commented Dec 15, 2021 •
edited
Loading

@claudiopro do we need a backport here? I'm thinking no.

@weltenwort
Copy link
Member

I didn't backport the corresponding PR for the infra plugin because the theme provider doesn't seem to be available in 8.0.

matschaffer added a commit that referenced this pull request Dec 16, 2021
@matschaffer
[Stack Monitoring] Use KibanaThemeProvider in the Stack Monitoring UI…
f93c36e 
… toast notifications (#120713)

This PR originally added the KibanaThemeProvider to stack monitoring as well, but #120968 was opened to do the same thing.

Instead this change focuses on updating the toMountPoint calls found in stack monitoring toast notifications to ensure they're either handled by simple i18n calls or appropriately pass a theme$ argument when called.
@claudiopro
Copy link
Contributor Author

@matschaffer @weltenwort That's my understanding too, but happy to backport if needed.

@claudiopro claudiopro deleted the issue_120896 branch December 16, 2021 19:02
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@claudiopro @TinLe
[Observability] Passes theme$ to toMountPoint (elastic#120968)
e2c723b 
* Treats toMountPoint - part II

* Adds theme$ to exploratory view config

* Uses theme$ from useExploratoryView hook

* Uses theme$ in HeaderActionMenuContext

* Better props for MonitoringApp
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@matschaffer @TinLe
[Stack Monitoring] Use KibanaThemeProvider in the Stack Monitoring UI…
6493d62 
… toast notifications (elastic#120713)

This PR originally added the KibanaThemeProvider to stack monitoring as well, but elastic#120968 was opened to do the same thing.

Instead this change focuses on updating the toMountPoint calls found in stack monitoring toast notifications to ensure they're either handled by simple i18n calls or appropriately pass a theme$ argument when called.
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
@claudiopro @gbamparop
[Observability] Passes theme$ to toMountPoint (elastic#120968)
0e87474 
* Treats toMountPoint - part II

* Adds theme$ to exploratory view config

* Uses theme$ from useExploratoryView hook

* Uses theme$ in HeaderActionMenuContext

* Better props for MonitoringApp
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
@matschaffer @gbamparop
[Stack Monitoring] Use KibanaThemeProvider in the Stack Monitoring UI…
0308fe5 
… toast notifications (elastic#120713)

This PR originally added the KibanaThemeProvider to stack monitoring as well, but elastic#120968 was opened to do the same thing.

Instead this change focuses on updating the toMountPoint calls found in stack monitoring toast notifications to ensure they're either handled by simple i18n calls or appropriately pass a theme$ argument when called.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@phillipb phillipb phillipb approved these changes

@awahab07 awahab07 awahab07 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Actionable Observability] Adapt Observability Alerts to use the new KibanaThemeProvider
9 participants
@claudiopro @elasticmachine @matschaffer @kibana-ci @kibanamachine @weltenwort @sorenlouv @phillipb @awahab07