[ML] Data visualizer: Use KibanaThemeProvider #121286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
chore
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
This was referenced Dec 15, 2021
| @@ -37,6 +38,7 @@ export interface DataVisualizerStartDependencies { | |||
| security?: SecurityPluginSetup; | |||
| share: SharePluginStart; | |||
| lens?: LensPublicStart; | |||
| charts?: ChartsPluginStart; | |||
There was a problem hiding this comment.
charts is now a required plugin and so doesn't need to be optional here.
There was a problem hiding this comment.
Changed in 69c0bd3
| } = useDataVisualizerKibana(); | ||
|
|
||
| const chartTheme = charts?.theme.useChartsTheme(); |
There was a problem hiding this comment.
Making charts non optional as per my previous comment means we can lose the ? here
There was a problem hiding this comment.
Changed in 69c0bd3
|
Tested and LGTM 🎉 |
qn895
approved these changes
Dec 15, 2021
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
* [ML] Data visualizer: Use KibanaThemeProvider * [ML] Edits following review
gbamparop
pushed a commit
to gbamparop/kibana
that referenced
this pull request
Jan 12, 2022
* [ML] Data visualizer: Use KibanaThemeProvider * [ML] Edits following review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adapts the
data_visualizerplugin to use theKibanaThemeProviderimplementation.Also contains a fix for the document count chart when viewing inside the ML plugin in dark theme, where the mouseover highlight wasn't adapting to the theme - the theme is now passed to the elastic chart in the
Settingssection.Before:
After:
Part of #119007 and #118866.
Checklist