[Fleet] Use KibanaThemeProvider #122385
Merged
[Fleet] Use KibanaThemeProvider #122385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
added
chore
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
approved these changes
Jan 6, 2022
joshdover
reviewed
Jan 6, 2022
| const portalNode = useMemo(() => createPortalNode(), []); | ||
|
|
||
| useEffect(() => { | ||
| setHeaderActionMenu((element) => { | ||
| const mount = toMountPoint(<OutPortal node={portalNode} />); | ||
| const mount = toMountPoint(<OutPortal node={portalNode} />, { theme$ }); |
There was a problem hiding this comment.
non-blocking question: if we forget to do this in the future, do we get some kind of runtime or type check error?
There was a problem hiding this comment.
@joshdover Not currently, I guess once all existing cases have been moved over the core team may be able to add some more strict checking?
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @hop-dev |
gbamparop
pushed a commit
to gbamparop/kibana
that referenced
this pull request
Jan 12, 2022
* fleet app * integrations app * reinstate EUITHemeProvider * add theme$ to integrations header portal * add theme$ to PackageInstallProvider * add theme$ to UpdateButton Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #119250. (Part of #118866)
Wrap our apps in
KibanaThemeProvider, and supplytheme$to alltoMountPointcalls.