[SLM] Hide system indices in snapshot restore flow

[sabarasaba]

Partially addresses #120314

Summary

The restore snapshot wizard lets you select system indices to restore. However, a restore request that includes a system index returns an error. Since we currently use the get snapshot api, we can leverage the feature_states array (which gives us a list of system indices in the snapshot) in order to create a new array of "normal" indices that don't include any system ones.

Steps to test:

1. Run elasticsearch with yarn es snapshot --license=trial -E path.repo=/tmp/es-backups and also run kibana
2. Navigate to console and run the following command to create a repository:

.PUT /_snapshot/my_backup
{
  "type": "fs",
  "settings": {
    "location": "/tmp/es-backups",
    "chunk_size": "10mb"
  }
}

3. Go to the homepage and add sample data so that we have some indices to play with
4. Go to snapshot and restore app and create a new policy and leave all default values as they are. Run the policy.
5. Go to the snapshots tab and verify that in the details flyout there are no system indices listed
6. Verify that clicking restore and disabling the toggle from the Data streams and indices section also doesn't list any system indices.

Note: here's a list of system index patterns elastic/elasticsearch#50251

[elasticmachine]

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

[sabarasaba]

@elasticmachine merge upstream

[yuliacech]

Thank you so much for fixing this issue, @sabarasaba!
I tested locally and can confirm that system indices are no longer listed in the indices list. I noticed a pre-existing issue: it's possible to provide an index pattern that doesn't match any indices in the snapshot. Doing so doesn't result in an error, but I think it also doesn't restore anything. I think it would be better to only allow index patterns that match something. I'll open an issue for that.

[sabarasaba]

@elasticmachine merge upstream

[sabarasaba]

Thanks for having a look and creating that issue @yuliacech!

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 21b2505
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
snapshotRestore	258.6KB	258.6KB	+8.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
snapshotRestore	26.6KB	26.7KB	+52.0B

History

• 💚 Build #18655 succeeded b11cfc7
• 💚 Build #18387 succeeded 00ede53
• 💚 Build #18386 succeeded 0a7f05e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

[kibanamachine]

💔 Backport failed

The pull request could not be backported due to the following error:
There are no branches to backport to. Aborting.

How to fix

Re-run the backport manually:

node scripts/backport --pr 123365

Questions ?

Please refer to the Backport tool documentation