Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Wrap APM/UX apps in KibanaThemeProvider #123910

Merged
merged 3 commits into from
Jan 28, 2022
Merged

[APM] Wrap APM/UX apps in KibanaThemeProvider #123910

merged 3 commits into from
Jan 28, 2022

Conversation

dgieselaar
Copy link
Member

Closes #118869.

@dgieselaar dgieselaar added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Jan 27, 2022
@dgieselaar dgieselaar requested review from a team as code owners January 27, 2022 11:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@dgieselaar dgieselaar enabled auto-merge (squash) January 27, 2022 11:59
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +122.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit d4398fc into elastic:main Jan 28, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.2 The branch "8.2" is invalid or doesn't exist

How to fix

Re-run the backport manually:

node scripts/backport --pr 123910

Questions ?

Please refer to the Backport tool documentation

awahab07 pushed a commit to awahab07/kibana that referenced this pull request Jan 31, 2022
@dgieselaar @awahab07
[APM] Wrap APM/UX apps in KibanaThemeProvider (elastic#123910)
69de24f
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 123910 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 1, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 123910 or prevent reminders by adding the backport:skip label.

@dgieselaar dgieselaar added the backport:skip This commit does not require backporting label Feb 2, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 2, 2022
@dgieselaar dgieselaar deleted the kibana-theme-provider branch February 2, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@gbamparop gbamparop gbamparop approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Use the new KibanaThemeProvider
6 participants
@dgieselaar @elasticmachine @kibana-ci @kibanamachine @shahzad31 @gbamparop