Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTR simulate mocha dry run #126702

Merged
merged 1 commit into from
Mar 3, 2022
Merged

FTR simulate mocha dry run #126702

merged 1 commit into from
Mar 3, 2022

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Mar 2, 2022

Summary

This PR works around a bug in mocha's dry run execution by collecting the tests without actually running mocha.

Details

  • This is a follow-up on FTR support mocha dry run #125915
  • It still uses the same output file
  • The created report structure is close to the json reporter output, just left away some execution specific fields:
    image
    image
  • Tested locally with the whole api_integration suite and with the whole functional suite to make sure it works for many entries

@pheyos pheyos added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v8.2.0 v7.17.2 v8.0.2 labels Mar 2, 2022
@pheyos pheyos requested a review from spalger March 2, 2022 17:13
@pheyos pheyos requested a review from a team as a code owner March 2, 2022 17:13
@pheyos pheyos self-assigned this Mar 2, 2022
spalger
spalger approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad to see this wasn't too hard to implement and that you were able to keep it isolated so we can just remove it once Mocha fixes their implementation 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/test 205 208 +3

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/test 5 6 +1
Unknown metric groups

API count

id before after diff
@kbn/test 241 244 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

@pheyos pheyos merged commit 954e3d3 into elastic:main Mar 3, 2022
@pheyos pheyos deleted the simulate_mocha_dry_run branch March 3, 2022 09:15
@kibanamachine kibanamachine mentioned this pull request Mar 3, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 3, 2022
@pheyos @kibanamachine
FTR simulate mocha dry run (elastic#126702)
ec23050 
This PR works around a bug in mocha's dry run execution by collecting the tests without actually running mocha.

(cherry picked from commit 954e3d3)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 3, 2022
@pheyos @kibanamachine
FTR simulate mocha dry run (elastic#126702)
7b0b66f 
This PR works around a bug in mocha's dry run execution by collecting the tests without actually running mocha.

(cherry picked from commit 954e3d3)
@kibanamachine kibanamachine mentioned this pull request Mar 3, 2022
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
✅ 8.1
❌ 7.17 Backport failed because of merge conflicts
✅ 8.0

How to fix

Re-run the backport manually:

node scripts/backport --pr 126702

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

pheyos added a commit to pheyos/kibana that referenced this pull request Mar 3, 2022
@pheyos
FTR simulate mocha dry run (elastic#126702)
9fea660 
This PR works around a bug in mocha's dry run execution by collecting the tests without actually running mocha.

(cherry picked from commit 954e3d3)

# Conflicts:
#	packages/kbn-test/src/functional_test_runner/functional_test_runner.ts
@pheyos pheyos mentioned this pull request Mar 3, 2022
Merged
@pheyos
Copy link
Member Author

pheyos commented Mar 3, 2022

💚 All backports created successfully

Status Branch Result
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 3, 2022
@kibanamachine @pheyos
FTR simulate mocha dry run (#126702) (#126754)
4085704 
This PR works around a bug in mocha's dry run execution by collecting the tests without actually running mocha.

(cherry picked from commit 954e3d3)

Co-authored-by: Robert Oskamp <[email protected]>
pheyos added a commit that referenced this pull request Mar 3, 2022
@pheyos
FTR simulate mocha dry run (#126702) (#126755)
fdb3ddf 
This PR works around a bug in mocha's dry run execution by collecting the tests without actually running mocha.

(cherry picked from commit 954e3d3)

# Conflicts:
#	packages/kbn-test/src/functional_test_runner/functional_test_runner.ts
kibanamachine added a commit that referenced this pull request Mar 3, 2022
@kibanamachine @pheyos
FTR simulate mocha dry run (#126702) (#126753)
d164f21 
This PR works around a bug in mocha's dry run execution by collecting the tests without actually running mocha.

(cherry picked from commit 954e3d3)

Co-authored-by: Robert Oskamp <[email protected]>
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 8, 2022
@pheyos @lucasfcosta
FTR simulate mocha dry run (elastic#126702)
8a76472 
This PR works around a bug in mocha's dry run execution by collecting the tests without actually running mocha.
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 8, 2022
@pheyos @lucasfcosta
FTR simulate mocha dry run (elastic#126702)
4c47f75 
This PR works around a bug in mocha's dry run execution by collecting the tests without actually running mocha.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees

@pheyos pheyos

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.17.2 v8.0.2 v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pheyos @kibana-ci @kibanamachine @spalger