Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data views] data view display name should be lower case #127533

Merged
merged 3 commits into from
Mar 15, 2022
Merged

[data views] data view display name should be lower case #127533

merged 3 commits into from
Mar 15, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Mar 11, 2022 •
edited
Loading

Summary

Addresses #109821 (comment)

Fixes this - Screen Shot 2022-03-09 at 4 02 14 PM

@mattkime mattkime changed the title data view should be lower case in this particular instance [data views] data view display name should be lower case Mar 11, 2022
@mattkime mattkime added v8.2.0 v8.1.1 v8.0.2 Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppServicesSv release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 11, 2022
@mattkime mattkime marked this pull request as ready for review March 11, 2022 03:08
@mattkime mattkime requested a review from a team as a code owner March 11, 2022 03:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@mattkime mattkime mentioned this pull request Mar 11, 2022
Merged
@mattkime
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit 2ec0a19 into elastic:main Mar 15, 2022
kibanamachine pushed a commit that referenced this pull request Mar 15, 2022
@mattkime
data view should be lower case in this particular instance (#127533)
ded8075 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 2ec0a19)
@kibanamachine kibanamachine mentioned this pull request Mar 15, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Mar 15, 2022
@mattkime
data view should be lower case in this particular instance (#127533)
fa1a7fa 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 2ec0a19)
@kibanamachine kibanamachine mentioned this pull request Mar 15, 2022
Closed
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1
✅ 8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 15, 2022
@kibanamachine @mattkime
data view should be lower case in this particular instance (#127533) (#…
0c9b531 
…127813)

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 2ec0a19)

Co-authored-by: Matthew Kime <[email protected]>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 17, 2022
@mattkime mattkime removed the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 17, 2022
maksimkovalev pushed a commit to maksimkovalev/kibana that referenced this pull request Mar 18, 2022
@mattkime @kibanamachine @maksimkovalev
data view should be lower case in this particular instance (elastic#1…
05db4ac 
…27533)

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@mattkime mattkime removed backport missing Added to PRs automatically when the are determined to be missing a backport. v8.0.2 labels Mar 22, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivindera shivindera shivindera approved these changes

Assignees
No one assigned
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v8.1.1 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattkime @elasticmachine @kibana-ci @kibanamachine @shivindera