Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Service groups: Add EuiTour steps for assisting users in creating their first service group and provide guidance on the navigation changes #128068

Merged
merged 10 commits into from
Mar 23, 2022
Merged

[APM] Service groups: Add EuiTour steps for assisting users in creating their first service group and provide guidance on the navigation changes #128068

merged 10 commits into from
Mar 23, 2022

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Mar 18, 2022 •
edited
Loading

closes #125209

groups.tour.mov

Open issues and questions:

@cauemarcondes cauemarcondes added Team:APM All issues that need APM UI Team support backport:skip This commit does not require backporting 8.2 candidate considered, but not committed, for 8.2 release labels Mar 18, 2022
@cauemarcondes cauemarcondes requested a review from a team as a code owner March 18, 2022 15:01
@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v8.2.0 and removed 8.2 candidate considered, but not committed, for 8.2 release labels Mar 18, 2022
@formgeist
Copy link
Contributor

After the user clicks on Create group or Edit Group, should I automatically dismiss the tour?

Yes, I believe the tour instance should close in this case, because the user is doing the action we intend them to perform in this case cc @boriskirov

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes
Copy link
Contributor Author

After the user clicks on Create group or Edit Group, should I automatically dismiss the tour?

Yes, I believe the tour instance should close in this case, because the user is doing the action we intend them to perform in this case cc @boriskirov

Done here 7ba3739.

And if the user clicks on any service group card, I also dismiss the tour on the All services card.

formgeist
formgeist reviewed Mar 22, 2022
View reviewed changes
Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cauemarcondes Overall steps content and functionality looks great, just some minor nits to the content and docs links formatting.

x-pack/plugins/apm/public/components/app/service_groups/service_groups_tour.tsx Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/app/service_groups/service_groups_tour.tsx Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/app/service_groups/service_groups_tour.tsx Outdated Show resolved Hide resolved
ogupte
ogupte approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments for feedback, but it looks good after that!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1177 1181 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.9MB 2.9MB +2.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

formgeist
formgeist approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@cauemarcondes cauemarcondes merged commit 30b5075 into elastic:main Mar 23, 2022
@cauemarcondes cauemarcondes deleted the apm-service-groups-tour branch March 23, 2022 13:25
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request Mar 23, 2022
@cauemarcondes @patrykkopycinski
[APM] Service groups: Add EuiTour steps for assisting users in creati…
cf082dd 
…ng their first service group and provide guidance on the navigation changes (elastic#128068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 left review comments

@ogupte ogupte ogupte approved these changes

@formgeist formgeist formgeist approved these changes

@boriskirov boriskirov Awaiting requested review from boriskirov

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.2.0
Projects
None yet
Milestone
No milestone
6 participants
@cauemarcondes @formgeist @kibana-ci @ogupte @bmorelli25 @kibanamachine