Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v52.2.0 #128841

Merged
merged 16 commits into from
Mar 30, 2022
Merged

Upgrade EUI to v52.2.0 #128841

merged 16 commits into from
Mar 30, 2022

Conversation

cee-chen
Copy link
Member

NOTE

This PR is #128313, but with a11y failures in main addressed (73e12ce).

This will be admin merged by @tylersmalley without all CODEOWNER approvals when tests pass.

Summary

[email protected][email protected]

  • Snapshot churn is largely due to mocked EuiIcon content including the aria-label as text. This helps the automated a11y testing suite, but the EUI team is evaluating a different approach that would be less invasive. It's possible that these snapshot changes will be negated in the next release of EUI.

52.2.0

  • Added branchUser, desktop and sessionViewer glyphs to EuiIcon (#5740)

52.1.0

  • Added anchor prop to EuiTourStep to allow for DOM selector attachment (#5696)
  • EuiDataGrid now forces isExpandable to be true if any cellActions are passed, as keyboard users are otherwise unable to access cell actions without the expansion popover (#5710)

Bug fixes

  • Fixed EuiDataGrid not rerendering correctly on row heights change (#5712)
  • Fixed EuiContextMenu requiring two tab keypresses to advance to the next focusable menu item (#5719)
  • Fixed EuiDataGrid footer cell focus bugging out after moving its column (#5720)

52.0.0

  • Added editorChecklist glyph to EuiIcon (#5705)
  • Updated testenv mock for EuiIcon to render aria-label as text (#5709)
  • Added compressed prop to EuiFilterGroup and reduced the size of the EuiFilterButton notification badge (#5717)
  • Increased contrast of EuiSelectableTemplateSitewide input text when in dark header (#5724)

Breaking changes

  • Removed Legacy theme including compiled CSS (#5688)
  • Removed flush and size props in EuiFilterButtonProps (#5717)

CSS-in-JS conversions

  • Converted EuiMark to CSS-in-JS styling (#4575)

breehall and others added 15 commits March 29, 2022 15:11
…pshots, and updated equality conditions for specific test cases
…ing for strict text equality to account for text coming from the EuiScreenReaderOnly component. Also updated tests to account for EuiIcon text that is now rendered when the icon is imported from .testenv (PR 5709 - elastic/eui#5709).
…apshots.

Updated tests using getAllByLabelText and getByLabelText to getAllByText and getByText respectively as the former have been deprecated
…pshots. Updated instances of getByLabelText and getAllByLabelText to getByText and getAllByText as the former are now deprecated.
… Updated required snapshots. Updated various tests to account for text rendering of the EuiIcon text.
@cee-chen cee-chen requested review from a team as code owners March 29, 2022 22:30
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Mar 29, 2022
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Mar 29, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@tylersmalley tylersmalley added v8.2.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 29, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

@cee-chen cee-chen changed the title Upgrade EUI to v52.1.0 Upgrade EUI to v52.2.0 Mar 29, 2022
- these changes should be reverted if we opt to revert the above PR
@cee-chen cee-chen requested a review from a team as a code owner March 29, 2022 23:06
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Security Solution Tests / value lists user with restricted access role "before each" hook for "Does not allow a t1 analyst user to upload a value list"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB -1.0B
infra 1002.1KB 1002.1KB -9.0B
total -10.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-css 595.5KB 595.5KB -47.0B
kbnUiSharedDeps-npmDll 4.8MB 4.8MB +557.0B
total +510.0B
Unknown metric groups

ESLint disabled in files

id before after diff
apm 15 14 -1
osquery 5 4 -1
securitySolution 69 68 -1
uptime 7 6 -1
total -4

ESLint disabled line counts

id before after diff
apm 88 85 -3
enterpriseSearch 9 7 -2
fleet 47 46 -1
osquery 122 119 -3
uptime 49 43 -6
total -15

References to deprecated APIs

id before after diff
canvas 70 64 -6
dashboard 78 72 -6
data 475 465 -10
dataEnhanced 55 49 -6
discover 26 20 -6
fleet 20 19 -1
lens 18 14 -4
management 2 1 -1
maps 456 330 -126
monitoring 40 28 -12
upgradeAssistant 12 7 -5
visDefaultEditor 205 155 -50
visTypeVega 4 3 -1
visualizations 17 13 -4
total -238

Total ESLint disabled count

id before after diff
apm 103 99 -4
enterpriseSearch 9 7 -2
fleet 55 54 -1
osquery 127 123 -4
securitySolution 510 509 -1
uptime 56 49 -7
total -19

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit 2688cb2 into elastic:main Mar 30, 2022
@cee-chen cee-chen deleted the upgrade-eui-52.1.0 branch March 30, 2022 03:52
@yuliacech
Copy link
Contributor

Thanks a lot for fixing this, @constancecchen @tylersmalley!

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128841 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 1, 2022
@cee-chen cee-chen added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.2.0 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants