Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure timezone attribute in tests is adhered to #13121

Conversation

stacey-gammon
Copy link
Contributor

Two issues:

  1. the archiver was loading the visualize mapping after the config setting so it was bring overwritten
  2. uiSettings.replace wasn’t working correctly to begin with.

cc @tylersmalley @spalger

Two issues - one the archiver was loading the visualize mapping after
the config setting so it was bring overwritten, and two,
uiSettings.replace wasn’t working correctly to begin with.
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for fixing this!

@stacey-gammon stacey-gammon merged commit fa302a1 into elastic:master Jul 26, 2017
stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Jul 26, 2017
* ensure timezone attribute is adhered to

Two issues - one the archiver was loading the visualize mapping after
the config setting so it was bring overwritten, and two,
uiSettings.replace wasn’t working correctly to begin with.

* extra line to ensure server is stabilized to prevent transitory failures
stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Jul 26, 2017
* ensure timezone attribute is adhered to

Two issues - one the archiver was loading the visualize mapping after
the config setting so it was bring overwritten, and two,
uiSettings.replace wasn’t working correctly to begin with.

* extra line to ensure server is stabilized to prevent transitory failures
stacey-gammon added a commit that referenced this pull request Jul 26, 2017
* ensure timezone attribute is adhered to

Two issues - one the archiver was loading the visualize mapping after
the config setting so it was bring overwritten, and two,
uiSettings.replace wasn’t working correctly to begin with.

* extra line to ensure server is stabilized to prevent transitory failures
stacey-gammon added a commit that referenced this pull request Jul 26, 2017
* ensure timezone attribute is adhered to

Two issues - one the archiver was loading the visualize mapping after
the config setting so it was bring overwritten, and two,
uiSettings.replace wasn’t working correctly to begin with.

* extra line to ensure server is stabilized to prevent transitory failures
@stacey-gammon stacey-gammon deleted the tests/make-visualize-tests-pass-locally branch October 24, 2017 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants