Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] [eslint-config-kibana] 0.9.0 and 0.10.0 #13318

Merged
merged 2 commits into from
Aug 3, 2017

Conversation

cjcenizal
Copy link
Contributor

Backports #13090 and #13259

CC @weltenwort

@cjcenizal cjcenizal merged commit 0ac9c2f into elastic:6.x Aug 3, 2017
@cjcenizal cjcenizal deleted the backport/13259/6.x branch August 3, 2017 15:49
@weltenwort
Copy link
Member

Just out of curiosity, do we need to backport changes to stuff in /packages? There is no useful way to match up the npm versions with the Kibana branches anyway.

@cjcenizal
Copy link
Contributor Author

cjcenizal commented Aug 3, 2017

Hmm... the way I'm looking at it is, if I check out a branch, I'd expect that branch to have a logical commit history and a consistent internal state. So, I'd find it a little strange if I know that we store the source for a dependency within the repo, yet that dependency's source is several versions behind the version we depend upon. It can seem like a mistake to someone who's reading the code. For that person to understand what's really going on, they'd need to check out another branch or poke around on GitHub. IMO, we should treat branches as self-contained units, so this kind of external exploration doesn't become necessary to understand the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants