Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y test for stack monitoring #134140

Merged
merged 8 commits into from
Jun 15, 2022
Merged

a11y test for stack monitoring #134140

merged 8 commits into from
Jun 15, 2022

Conversation

rashmivkulkarni
Copy link
Contributor

Meta: #51456

fixes : #80064 ( Kibana )

ref a11y issue found : #134139

@rashmivkulkarni rashmivkulkarni added Project:Accessibility test_ui_functional release_note:skip Skip the PR/issue when compiling release notes Team:Observability Team label for Observability Team (for things that are handled across all of observability) Feature:Stack Monitoring backport:skip This commit does not require backporting v8.4.0 labels Jun 9, 2022
@rashmivkulkarni rashmivkulkarni self-assigned this Jun 9, 2022
@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni rashmivkulkarni marked this pull request as ready for review June 14, 2022 15:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

rashmivkulkarni commented Jun 14, 2022 •
edited
Loading

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/742 ( build kite - 50 times on Flaky Test Runner) ( 50/50 - pass)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

cuff-links
cuff-links approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@cuff-links cuff-links left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rashmivkulkarni rashmivkulkarni merged commit 2a872ab into elastic:main Jun 15, 2022
@rashmivkulkarni rashmivkulkarni mentioned this pull request Jun 21, 2022
Open
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavyarm bhavyarm bhavyarm left review comments

@cuff-links cuff-links cuff-links approved these changes

@wayneseymour wayneseymour Awaiting requested review from wayneseymour

Assignees

@rashmivkulkarni rashmivkulkarni

Labels
backport:skip This commit does not require backporting Feature:Stack Monitoring Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Observability Team label for Observability Team (for things that are handled across all of observability) test_ui_functional v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack monitoring needs a11y tests
6 participants
@rashmivkulkarni @elasticmachine @kibana-ci @cuff-links @bhavyarm @kibanamachine