Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y tests for watcher. Minimal in scope. #135046

Merged
merged 6 commits into from
Jun 24, 2022
Merged

a11y tests for watcher. Minimal in scope. #135046

merged 6 commits into from
Jun 24, 2022

Conversation

rashmivkulkarni
Copy link
Contributor

Meta : #51456

@rashmivkulkarni rashmivkulkarni added the release_note:skip Skip the PR/issue when compiling release notes label Jun 23, 2022
@rashmivkulkarni rashmivkulkarni self-assigned this Jun 23, 2022
@rashmivkulkarni rashmivkulkarni added 8.4 candidate Project:Accessibility Feature:Watcher test_xpack_functional auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 23, 2022
@rashmivkulkarni rashmivkulkarni marked this pull request as ready for review June 23, 2022 20:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@rashmivkulkarni
Copy link
Contributor Author

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/776 - ( X50 - on Flaky test runner)

@rashmivkulkarni rashmivkulkarni added the backport:skip This commit does not require backporting label Jun 23, 2022
@bhavyarm
Copy link
Contributor

@rashmivkulkarni can you please update the description of the PR to say a11y tests for watcher. Minimal in scope? Thanks!

bhavyarm
bhavyarm approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please merge after flaky test runner green build.

@rashmivkulkarni rashmivkulkarni changed the title a11y watcher tests wip a11y tests for watcher. Minimal in scope. Jun 23, 2022
@rashmivkulkarni
Copy link
Contributor Author

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/778 - flaky test runner build successful. ( X50)

cuff-links
cuff-links approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@cuff-links cuff-links left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this earlier but for some reason it didn't post. LGTM. I ran it locally.

@rashmivkulkarni rashmivkulkarni enabled auto-merge (squash) June 24, 2022 00:42
@rashmivkulkarni rashmivkulkarni merged commit f75976f into elastic:main Jun 24, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

@rashmivkulkarni rashmivkulkarni mentioned this pull request Jun 24, 2022
Open
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavyarm bhavyarm bhavyarm approved these changes

@cuff-links cuff-links cuff-links approved these changes

Assignees

@rashmivkulkarni rashmivkulkarni

Labels
backport:skip This commit does not require backporting Feature:Watcher Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rashmivkulkarni @elasticmachine @bhavyarm @kibana-ci @cuff-links @kibanamachine