Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross cluster replication a11y tests #135514

Merged
merged 10 commits into from
Jul 4, 2022
Merged

Cross cluster replication a11y tests #135514

merged 10 commits into from
Jul 4, 2022

Conversation

cuff-links
Copy link
Contributor

Part of #51456

This test adds accessibility to the cross cluster replication app.

@cuff-links cuff-links added Team:QA Team label for QA Team Project:Accessibility Feature:CCR and Remote Clusters test_ui_functional test_xpack_functional Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Functional Testing auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 v8.3.1 labels Jun 30, 2022
@cuff-links
Copy link
Contributor Author

Flaky Test Runner run https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/822

@cuff-links
Copy link
Contributor Author

Flaky test runner had some strange failures in a couple dashboard tests due to sessions failing that were unrelated to these tests.

@cuff-links cuff-links marked this pull request as ready for review June 30, 2022 07:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@cuff-links
Copy link
Contributor Author

jenkins test this

1 similar comment
@cuff-links
Copy link
Contributor Author

jenkins test this

@cuff-links
Copy link
Contributor Author

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/823 All green flaky test runner run.

@cuff-links
Copy link
Contributor Author

@elasticmachine merge upstream

@cuff-links
Copy link
Contributor Author

@elasticmachine merge upstream

@cuff-links
Copy link
Contributor Author

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/834

@cuff-links cuff-links requested a review from bhavyarm July 1, 2022 01:15
bhavyarm
bhavyarm approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cuff-links
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cuff-links cuff-links merged commit b52ff2a into elastic:main Jul 4, 2022
@cuff-links cuff-links mentioned this pull request Jul 4, 2022
Open
77 tasks
kibanamachine pushed a commit that referenced this pull request Jul 4, 2022
Cross cluster replication a11y tests (#135514)
fa640b2 
* Added CCR a11y tests covering all screens.

* Fixed test that broke after update. Returned a method that was removed.

* Switched order of remote clusters a11y and ccr.

* Switched orders of ccr, snapshot and restore and remote cluster tets. They need to be ran in a certain order.

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Bhavya RM <[email protected]>
(cherry picked from commit b52ff2a)
@kibanamachine kibanamachine mentioned this pull request Jul 4, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 4, 2022
@kibanamachine
Cross cluster replication a11y tests (#135514) (#135666)
7535538 
* Added CCR a11y tests covering all screens.

* Fixed test that broke after update. Returned a method that was removed.

* Switched order of remote clusters a11y and ccr.

* Switched orders of ccr, snapshot and restore and remote cluster tets. They need to be ran in a certain order.

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Bhavya RM <[email protected]>
(cherry picked from commit b52ff2a)

Co-authored-by: John Dorlus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavyarm bhavyarm bhavyarm approved these changes

@wayneseymour wayneseymour Awaiting requested review from wayneseymour

@LeeDr LeeDr Awaiting requested review from LeeDr

@rashmivkulkarni rashmivkulkarni Awaiting requested review from rashmivkulkarni

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:CCR and Remote Clusters Feature:Functional Testing Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:QA Team label for QA Team test_ui_functional test_xpack_functional v8.3.1 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cuff-links @elasticmachine @kibana-ci @kibanamachine @bhavyarm