[Fleet] Support new subscription and license fields #137799
Conversation
jen-huang
added
release_note:enhancement
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
| type: string | ||
| enum: | ||
| - Apache-2.0 | ||
| - Elastic-2.0 |
There was a problem hiding this comment.
are these the only possible values?
There was a problem hiding this comment.
| @@ -392,3 +392,15 @@ export function getNoticePath(paths: string[]): string | undefined { | |||
|
|
|||
| return undefined; | |||
| } | |||
|
|
|||
| export function getLicensePath(paths: string[]): string | undefined { | |||
There was a problem hiding this comment.
it would be nice to unit test this function
| // Simulate a long text while loading | ||
| <> | ||
| <p> | ||
| <EuiLoadingContent lines={5} /> |
There was a problem hiding this comment.
i copied this from the notice_modal that we already had in the same directory... can't take too much credit :D
| <EuiModal maxWidth={true} onClose={onClose}> | ||
| <EuiModalHeader> | ||
| <EuiModalHeaderTitle> | ||
| <h1>LICENSE.txt</h1> |
There was a problem hiding this comment.
Should we display the file name from license field, I think it is not always LICENSE.txt?
There was a problem hiding this comment.
the file is always LICENSE.txt but yes we should display the name of the license instead (like Apache 2.0)
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: cc @jen-huang |
Summary
Part of elastic/package-spec#298. This PR adds support for the new
source.licenseandconditions.elastic.subscriptionfields in packages:source.licenseis a new field containing the name of the license of the package, i.e.Apache 2.0LICENSE.txtfile lives at the root of the package. This PR adjusts the package info endpoint to return the path to the license file. The package details UI surfaces the license contents in a modalconditions.elastic.subscriptionis a field reflecting the necessary Elastic subscription needed to install the package, it replaced the now deprecated top-levellicensefieldlicensewhen the new field is not availableTesting
elastic-packageto buildgoodpackagegoodpackage to{package registry root}/testdata/packagegoodpackage and verify that subscription and license information exists. Check details of any other package and verify that subscription details are as expected.Screenshots