Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detections] fixes failing tests for 8.4 prebuilt rules update #138794

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Aug 15, 2022

@vitaliidm vitaliidm self-assigned this Aug 15, 2022
@vitaliidm vitaliidm added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels Aug 15, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@vitaliidm vitaliidm marked this pull request as ready for review August 15, 2022 13:09
@vitaliidm vitaliidm requested a review from a team as a code owner August 15, 2022 13:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@vitaliidm vitaliidm added the release_note:skip Skip the PR/issue when compiling release notes label Aug 15, 2022
@banderror banderror requested review from a team and xcrzx and removed request for banderror and a team August 15, 2022 15:23
Copy link
Contributor

@xcrzx xcrzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vitaliidm vitaliidm merged commit 167bb8e into elastic:main Aug 15, 2022
@vitaliidm vitaliidm deleted the detections/fixes-rest-8_4-prebuilt-rules-tests branch August 15, 2022 15:54
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 15, 2022
…rules update elastic#138794

- fixes the rest of tests for elastic#138574 PR

(cherry picked from commit 167bb8e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit to dimaanj/kibana that referenced this pull request Aug 15, 2022
…rules update elastic#138794 (elastic#138832)

- fixes the rest of tests for elastic#138574 PR

(cherry picked from commit 167bb8e)

Co-authored-by: Vitalii Dmyterko <[email protected]>
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants