Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K7][UI Framework]: Progress bar component #14003

Merged
merged 4 commits into from
Sep 15, 2017

Conversation

snide
Copy link
Contributor

@snide snide commented Sep 14, 2017

Adds a progress bar component using the HTML5 <progress> element.

Has the following abilities.

  • Progress can have size and color.
  • Progress can be indeterminate.
  • Progress can be static, fixed or absolute in position.

TODO:

  • Firefox doesn't allow animations or pseudo selectors on the <progress> html element, which is a problem for my indeterminate option. I'll need to create a fallback, or (hopefully not) drop this to a simple <div> system.

@snide snide added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Sep 14, 2017
@snide
Copy link
Contributor Author

snide commented Sep 15, 2017

I couldn't think of any tricks to handle the Firefox issue. I modified the component to use a single <div /> when in an indeterminate state. It uses a <progress> tag when in a determinate state.

@snide snide merged commit 0709859 into elastic:k7-ui-framework Sep 15, 2017
@snide snide deleted the k7/progress branch September 15, 2017 19:46
cjcenizal pushed a commit that referenced this pull request Sep 19, 2017
* progress bar component

* fix some moz issues

* typo

* indeterminate progress bar uses a div because of FF
@cjcenizal
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants