Kibana index template #14112
Merged
Kibana index template #14112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Core
spalger
force-pushed
the
implement/kibana-index-template
branch
3 times, most recently
from
b2f64cc
to
c4c739c
Compare
The SavedObjects code defines `isEsUsable$` and `testEsAvailability$` to negotiate whether SavedObjectClients should be attempting to communicate to elasticsearch.
- `isEsUsable$`
- can be either `undefined`, `true`, or `false`
- if `isEsUsable === undefined`
- All requests are paused
- if `isEsUsable === false`
- Send 503 to all paused and future requests
- if `isEsUsable === true`
- Request are sent to elasticsearch
- `testEsAvailability$`
- emits when:
- elasticsearch plugin is accessible
- a request to es is blocked
- es does not respond, or responds with a status >= 500
- on each event:
- set `isEsUsable` to `undefined`
- attempt to put the index template to elasticsearch
- set `isEsUsable` to wether putTemplate was successful
…nd something else
spalger
force-pushed
the
implement/kibana-index-template
branch
from
06311d1
to
70a224e
Compare
|
This was accidentally closed because I don't know how to Github desktop.... |
|
Replaced by #14142 |
This was referenced Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Based on #14092
Fixes #12819
Completely removes SavedObject index management from the health check and to own internal "esAvailability" check.
This check currently attempts to write an index template to the kibana index (throttled to one attempt per second) when:
callClusterrejects with an error with a >= 500callClusterrejects with an error that has no status codeSavedObjectsClientuses itscallClusterfunction after we failed to create the index templatesWe still need to patch the Kibana index if it already exists and we need a 🐃 of tests, but I'm excited by how this is coming along.