[errors/multi.allow_explicit_index] move error handling to browser #14184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A part of elastic#14163, this removes the portion of the healthCheck that tries to verify that rest.action.multi.allow_explicit_index is not set to false. Instead, a ui module was created that will check errors from elasticsearch for this specific scenario, and exposes a method that will display a nicer "fatal error" screen that informs the user about what they should do, and navigates away from the now broken app.
…-allow-explicit-index-handler
|
This is my favorite error message in all of Kibana. Seriously. We should update all gracefully handled errors (e.g. xpack auth issues for monitoring/security/reporting) with a page like this. It's slightly playful but not over the top. It explains what the problem is, why it's a problem for Kibana, and how to remedy it. cc @elastic/kibana-monitoring @elastic/kibana-sharing |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Oct 3, 2017
kimjoar
approved these changes
Oct 3, 2017
| <h3>Ok, how do I fix this?</h3> | ||
| <ol> | ||
| <li>Remove <code>rest.action.multi.allow_explicit_index: false</code> from your Elasticsearch config file.</li> | ||
| <li>Restart elasticsearch.</li> |
There was a problem hiding this comment.
elasticsearch -> Elasticsearch
…-allow-explicit-index-handler
spalger
added a commit
that referenced
this pull request
Oct 4, 2017
…14184) * [errors/multi.allow_explicit_index] move error handling to browser A part of #14163, this removes the portion of the healthCheck that tries to verify that rest.action.multi.allow_explicit_index is not set to false. Instead, a ui module was created that will check errors from elasticsearch for this specific scenario, and exposes a method that will display a nicer "fatal error" screen that informs the user about what they should do, and navigates away from the now broken app. * [es/healthCheck] remove old test * fix typo (cherry picked from commit 2b7808b)
|
6.x/6.1: 375d5b6 |
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Nov 20, 2017
…lastic#14184) * [errors/multi.allow_explicit_index] move error handling to browser A part of elastic#14163, this removes the portion of the healthCheck that tries to verify that rest.action.multi.allow_explicit_index is not set to false. Instead, a ui module was created that will check errors from elasticsearch for this specific scenario, and exposes a method that will display a nicer "fatal error" screen that informs the user about what they should do, and navigates away from the now broken app. * [es/healthCheck] remove old test * fix typo
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Dec 1, 2017
…lastic#14184) * [errors/multi.allow_explicit_index] move error handling to browser A part of elastic#14163, this removes the portion of the healthCheck that tries to verify that rest.action.multi.allow_explicit_index is not set to false. Instead, a ui module was created that will check errors from elasticsearch for this specific scenario, and exposes a method that will display a nicer "fatal error" screen that informs the user about what they should do, and navigates away from the now broken app. * [es/healthCheck] remove old test * fix typo
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #14163, this removes the portion of the healthCheck that tries to verify that rest.action.multi.allow_explicit_index is not set to false. Instead, a ui module was created that will check errors from elasticsearch for this specific scenario, and exposes a method that will display a nicer "fatal error" screen that informs the user about what they should do, and navigates away from the now broken app.
Please, suggest as many edits as you like to the error page text. I'm horrible at this stuff.
To test this out run: