[Fleet] Rely on package content during installation

[criamico]

Summary

Closes #115032

Removing the call to getInfo in Registry.getRegistryPackage with generatePackageInfoFromArchiveBuffer to reduce the dependency from the registry.

Tests

1. Try to install any package, it should work as usual
2. Run this script: node x-pack/plugins/fleet/scripts/install_all_packages/index.js - Remember to add the static path to the kibana url if you use one:

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list

[criamico]

@elasticmachine merge upstream

[criamico]

@elasticmachine merge upstream

[criamico]

@elasticmachine merge upstream

[criamico]

This function internally calls getInfo to retrieve the ArchiveBuffer:

kibana/x-pack/plugins/fleet/server/services/epm/registry/index.ts

Lines 312 to 330 in 4019d37

	export async function fetchArchiveBuffer({
	pkgName,
	pkgVersion,
	shouldVerify,
	ignoreUnverified = false,
	}: {
	pkgName: string;
	pkgVersion: string;
	shouldVerify: boolean;
	ignoreUnverified?: boolean;
	}): Promise<{
	archiveBuffer: Buffer;
	archivePath: string;
	verificationResult?: PackageVerificationResult;
	}> {
	const logger = appContextService.getLogger();
	const { download: archivePath } = await getInfo(pkgName, pkgVersion);
	const archiveUrl = `${getRegistryUrl()}${archivePath}`;
	const archiveBuffer = await getResponseStream(archiveUrl).then(streamToBuffer);

I wonder if I should get the ArchiveBuffer from the cache instead and remove the calls to getInfo altogether.

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[criamico]

@elasticmachine merge upstream

[banderror]

Changes in x-pack/plugins/security_solution/server/lib/detection_engine/routes/fleet/get_installed_integrations/installed_integration_set.ts LGTM 👍

[criamico]

@elasticmachine merge upstream

[nchaulet]

it seems weird to me that getRegistryPackage return an ArchivePackage should this be a new method, or should rename it getPackage ?

[criamico]

calling it getPackage would be a good option. I've been in doubt about the naming because the whole flow is in Registry but it's not going to use the registry anymore.. I guess we'll have to refactor further

[criamico]

I changed the name to GetPackage, I will need additional approvals from other teams that also use that method.

[criamico]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/apm-ui (Team:APM)

[juliaElastic]

LGTM

[criamico]

@elasticmachine merge upstream

[sorenlouv]

apm changes lgtm

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: f494ac5

Metrics [docs]

✅ unchanged

History

• 💚 Build #78728 succeeded e69120b
• 💔 Build #78700 failed d4efcf1
• 💔 Build #78695 failed c50b7f6
• 💚 Build #78635 succeeded f5d89d8
• 💛 Build #78341 was flaky 3f0ba38
• 💛 Build #78267 was flaky 036a784

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

[hop-dev]

Code changes look good to me, thanks for this!

[dasansol92]

OLM changes (getRegistryPackage rename) LGTM!