Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing component exceptions from axe-core validation config #145059

Merged
merged 10 commits into from
Nov 28, 2023
Merged

Removing component exceptions from axe-core validation config #145059

merged 10 commits into from
Nov 28, 2023

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Nov 11, 2022 •
edited
Loading

These two EUI issues are fixed. So removing corresponding component exceptions

elastic/eui#4474
elastic/eui#4536

@bhavyarm bhavyarm self-assigned this Nov 11, 2022
@bhavyarm bhavyarm added Team:QA Team label for QA Team release_note:skip Skip the PR/issue when compiling release notes v8.6.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 11, 2022
@bhavyarm bhavyarm marked this pull request as ready for review November 11, 2022 20:24
@bhavyarm bhavyarm requested a review from a team as a code owner November 11, 2022 20:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@bhavyarm
Copy link
Contributor Author

@cuff-links this is the PR. Please note I get green with/without this PR on these tests in my local. Any inputs will be appreciated. Thanks!

@cuff-links
Copy link
Contributor

@bhavyarm This does not fail for me locally. I cannot reproduce this result.

@cuff-links
Copy link
Contributor

@elasticmachine merge upstream

@bhavyarm bhavyarm marked this pull request as draft November 17, 2022 15:30
@cuff-links
Copy link
Contributor

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1565#_

@bhavyarm bhavyarm removed Team:QA Team label for QA Team v8.6.0 labels Oct 31, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@bhavyarm bhavyarm marked this pull request as ready for review November 28, 2023 23:26
marius-dr
marius-dr approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@marius-dr marius-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Referenced issues were closed as fixed.

@bhavyarm bhavyarm added Project:Accessibility and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@bhavyarm bhavyarm merged commit e4816c6 into elastic:main Nov 28, 2023
34 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marius-dr marius-dr marius-dr approved these changes

Assignees

@bhavyarm bhavyarm

Labels
backport:skip This commit does not require backporting Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bhavyarm @elasticmachine @cuff-links @kibana-ci @marius-dr @kibanamachine