Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 'Save modal dark theme issues in Discover, Dashboard, and Maps' #149147

Merged
merged 6 commits into from
Jan 19, 2023
Merged

fix 'Save modal dark theme issues in Discover, Dashboard, and Maps' #149147

merged 6 commits into from
Jan 19, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 18, 2023 •
edited
Loading

Fixes #149130 and #142636

PR updates showSaveModal to wrap modal in KibanaThemeProvider to resolve dark theme issues. Rather than passing in theme$ as a new parameter, theme$ is imported from within the plugin itself.

ThomThomson
ThomThomson approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team changes LGTM! It's great to see the plugin system being actually used as a DI mechanism instead of making the consumers pass in common dependencies!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
savedObjects 37 38 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
embeddable 423 421 -2
savedObjects 156 155 -1
total -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 365.8KB 365.8KB -30.0B
discover 396.8KB 396.8KB -20.0B
graph 450.7KB 450.5KB -123.0B
maps 2.7MB 2.7MB -22.0B
visualizations 260.2KB 260.0KB -147.0B
total -342.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 70.6KB 70.5KB -87.0B
savedObjects 29.2KB 29.2KB +78.0B
total -9.0B
Unknown metric groups

API count

id before after diff
embeddable 524 522 -2
savedObjects 197 196 -1
total -3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese marked this pull request as ready for review January 18, 2023 20:37
@nreese nreese requested review from a team as code owners January 18, 2023 20:37
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.7.0 labels Jan 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@nreese nreese added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jan 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

lukasolson
lukasolson approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in Discover and the theme is applying correctly now.

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Jan 18, 2023
@ThomThomson
Copy link
Contributor

ThomThomson commented Jan 18, 2023 •
edited
Loading

@nreese, does this PR also close #142636?

@nreese
Copy link
Contributor Author

nreese commented Jan 18, 2023

@nreese, does this PR also close #142636?

Yes it does. I will update the description to include this issue. Thanks for linking

drewdaemon
drewdaemon approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from our end. Code review

@nreese nreese requested a review from nickpeihl January 18, 2023 21:56
nickpeihl
nickpeihl approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maps changes lgtm!

code review and tested dark mode in chrome

@nreese nreese merged commit d5f6fe8 into elastic:main Jan 19, 2023
This was referenced Jan 19, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

@lukasolson lukasolson lukasolson approved these changes

@nickpeihl nickpeihl nickpeihl approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save modal dark theme issues in Discover, Dashboard, and Maps
8 participants
@nreese @kibana-ci @elasticmachine @ThomThomson @drewdaemon @lukasolson @nickpeihl @kibanamachine