Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor map test #15000

Closed
wants to merge 2 commits into from
Closed

refactor map test #15000

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b1456a
disable flaky test
thomasneirynck Nov 16, 2017
bc7fa21
rearrange for clarity
thomasneirynck Nov 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 55 additions & 51 deletions test/functional/apps/visualize/_tile_map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,31 +173,31 @@ export default function ({ getService, getPageObjects }) {
*/
it('should save with zoom level and load, take screenshot', async function () {

const expectedZoom5Data = [
`- 9q5 91 { "lat": 34.2934322102855, "lon": -118.57068326651722 }`,
`- 9qc 89 { "lat": 38.64546895785822, "lon": -121.59105236401383 }`,
`- 9qh 74 { "lat": 34.18319454366291, "lon": -117.426273193009 }`,
`- 9y7 73 { "lat": 35.87868071952197, "lon": -96.3330221912275 }`,
`- 9ys 71 { "lat": 37.31065319536228, "lon": -94.82038319412567 }`,
`- 9yn 71 { "lat": 34.57203017311617, "lon": -92.17198946946104 }`,
`- 9q9 70 { "lat": 37.327310177098425, "lon": -121.70855726221842 }`,
`- 9zv 65 { "lat": 44.39887339514322, "lon": -93.34879252386207 }`,
`- 9yu 65 { "lat": 38.83211174621605, "lon": -94.76601768729205 }`,
`- 9y6 64 { "lat": 35.743489960441366, "lon": -97.75019769280334 }`
];

const expectedZoom6Data = [
`- c20g 16 { "lat": 45.59211894578766, "lon": -122.47455075674225 }`,
`- c28c 13 { "lat": 48.0181491561234, "lon": -122.43847891688347 }`,
`- c40b 11 { "lat": 56.34347582997923, "lon": -133.61804031343624 }`,
`- c2e5 11 { "lat": 48.46440218389034, "lon": -119.51805034652352 }`,
`- c262 10 { "lat": 46.56816971953958, "lon": -120.5440594162792 }`,
`- c23n 10 { "lat": 47.51524904742837, "lon": -122.26747375912964 }`,
`- 9rw6 10 { "lat": 42.59157135151327, "lon": -114.79671782813966 }`,
`- c2mq 9 { "lat": 47.547698873095214, "lon": -116.18850083090365 }`,
`- c27x 9 { "lat": 47.753206375055015, "lon": -118.7438936624676 }`,
`- c25p 9 { "lat": 46.30563497543335, "lon": -119.30418533273041 }`
];
// const expectedZoom5Data = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to the issue again and explain about why it's all commented out? Unless i don't see it, I think you had that in here before.

So the sort and prepData fixed the other functions but still not this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I'll llnk the issue again.

the prepData is just to simplify the code a little, while I was working on it. but those resolved errors i got locally, and have never seen in CI.

// `- 9q5 91 { "lat": 34.2934322102855, "lon": -118.57068326651722 }`,
// `- 9qc 89 { "lat": 38.64546895785822, "lon": -121.59105236401383 }`,
// `- 9qh 74 { "lat": 34.18319454366291, "lon": -117.426273193009 }`,
// `- 9y7 73 { "lat": 35.87868071952197, "lon": -96.3330221912275 }`,
// `- 9ys 71 { "lat": 37.31065319536228, "lon": -94.82038319412567 }`,
// `- 9yn 71 { "lat": 34.57203017311617, "lon": -92.17198946946104 }`,
// `- 9q9 70 { "lat": 37.327310177098425, "lon": -121.70855726221842 }`,
// `- 9zv 65 { "lat": 44.39887339514322, "lon": -93.34879252386207 }`,
// `- 9yu 65 { "lat": 38.83211174621605, "lon": -94.76601768729205 }`,
// `- 9y6 64 { "lat": 35.743489960441366, "lon": -97.75019769280334 }`
// ];

// const expectedZoom6Data = [
// `- c20g 16 { "lat": 45.59211894578766, "lon": -122.47455075674225 }`,
// `- c28c 13 { "lat": 48.0181491561234, "lon": -122.43847891688347 }`,
// `- c40b 11 { "lat": 56.34347582997923, "lon": -133.61804031343624 }`,
// `- c2e5 11 { "lat": 48.46440218389034, "lon": -119.51805034652352 }`,
// `- c262 10 { "lat": 46.56816971953958, "lon": -120.5440594162792 }`,
// `- c23n 10 { "lat": 47.51524904742837, "lon": -122.26747375912964 }`,
// `- 9rw6 10 { "lat": 42.59157135151327, "lon": -114.79671782813966 }`,
// `- c2mq 9 { "lat": 47.547698873095214, "lon": -116.18850083090365 }`,
// `- c27x 9 { "lat": 47.753206375055015, "lon": -118.7438936624676 }`,
// `- c25p 9 { "lat": 46.30563497543335, "lon": -119.30418533273041 }`
// ];
const vizName1 = 'Visualization TileMap';

// For some reason the map bounds right after saving a tile map for the first time are slightly different
Expand All @@ -206,39 +206,43 @@ export default function ({ getService, getPageObjects }) {
// In order to get this test to pass we'll re-open the saved visualization from the landing page.
await PageObjects.visualize.loadSavedVisualization(vizName1);

const firstMapBounds = await PageObjects.visualize.getMapBounds();
// const firstMapBounds = await PageObjects.visualize.getMapBounds();

//TODO: this has been failing intermettingly: https://github.com/elastic/kibana/issues/14920
await PageObjects.visualize.openSpyPanel();
await PageObjects.visualize.selectTableInSpyPaneSelect();
const actualZoom5Data = await PageObjects.visualize.getDataTableData();
compareTableData(expectedZoom5Data, actualZoom5Data.trim().split('\n'));
// await PageObjects.visualize.selectTableInSpyPaneSelect();
// const actualZoom5Data = await PageObjects.visualize.getDataTableData();
// compareTableData(expectedZoom5Data, actualZoom5Data.trim().split('\n'));

await PageObjects.visualize.closeSpyPanel();
await PageObjects.visualize.clickMapZoomIn();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guessing these lines are important to keep in for the next test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. it keeps zooming in. there's some mistake still..

await PageObjects.visualize.openSpyPanel();

const actualZoom6Data = await PageObjects.visualize.getDataTableData();
compareTableData(expectedZoom6Data, actualZoom6Data.trim().split('\n'));

await PageObjects.visualize.closeSpyPanel();

await PageObjects.visualize.loadSavedVisualization(vizName1);
await PageObjects.visualize.waitForVisualization();

const secondMapBounds = await PageObjects.visualize.getMapBounds();

expect(firstMapBounds.top_left.lat).to.equal(secondMapBounds.top_left.lat);
expect(firstMapBounds.top_left.long).to.equal(secondMapBounds.top_left.long);
expect(firstMapBounds.bottom_right.lat).to.equal(secondMapBounds.bottom_right.lat);
expect(firstMapBounds.bottom_right.long).to.equal(secondMapBounds.bottom_right.long);

await PageObjects.visualize.openSpyPanel();

await PageObjects.visualize.selectTableInSpyPaneSelect();
const actualReOpenedZoom5Data = await PageObjects.visualize.getDataTableData();
compareTableData(expectedZoom5Data, actualReOpenedZoom5Data.trim().split('\n'));

await PageObjects.visualize.closeSpyPanel();
//no clear resolution at this point, so comment out
// await PageObjects.visualize.openSpyPanel();
//
// const actualZoom6Data = await PageObjects.visualize.getDataTableData();
// compareTableData(expectedZoom6Data, actualZoom6Data.trim().split('\n'));
//
// await PageObjects.visualize.closeSpyPanel();
//
// await PageObjects.visualize.loadSavedVisualization(vizName1);
// await PageObjects.visualize.waitForVisualization();
//
// const secondMapBounds = await PageObjects.visualize.getMapBounds();
//
// expect(firstMapBounds.top_left.lat).to.equal(secondMapBounds.top_left.lat);
// expect(firstMapBounds.top_left.long).to.equal(secondMapBounds.top_left.long);
// expect(firstMapBounds.bottom_right.lat).to.equal(secondMapBounds.bottom_right.lat);
// expect(firstMapBounds.bottom_right.long).to.equal(secondMapBounds.bottom_right.long);
//
// await PageObjects.visualize.openSpyPanel();
//
// await PageObjects.visualize.selectTableInSpyPaneSelect();
// const actualReOpenedZoom5Data = await PageObjects.visualize.getDataTableData();
// compareTableData(expectedZoom5Data, actualReOpenedZoom5Data.trim().split('\n'));
//
// await PageObjects.visualize.closeSpyPanel();
});

it('should zoom in to level 10', function () {
Expand Down