Add possibility to hide "panel spy" #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
work as collapse/collapsable
work as collapse/collapsable
work as collapse/collapsable
work as collapse/collapsable
work as collapse/collapsable
work as collapse/collapsable
work as collapse/collapsable
work as collapse/collapsable
work as collapse/collapsable
|
I think I'd rather not go down the path of having hidden options to disable specific options in the editor. |
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
Sep 13, 2018
* chore: make labeled select generic component decouple it from the extended input template so it can be reused * feat: add container style argType UI * feat: add border radius to border form * chore: separate background color and image also, don't automatically append the 'px' on padding and border radius * fix: make labeled select value optional * feat: add container appearance form * fix: correctly build border property also make the value argument optional * feat: set the container ast also set the expected types on css values to string instead of number, since we're using the px values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Collapsable" enables the possibility to collapse a panel using "collapse" parameter in the dashboard configuration.
I just did the same : "spyable" enable the possibility to "spy" a panel. By setting spyable "true", the "panel spy" part of the editor is hide.
Because something you want to allow edition but not spy. With these changes, it will not be possible to enable spy through the editor.