Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Posture] [Vulnerability Management] Add beta tooltip info (findings page) #155607

Merged
merged 1 commit into from
Apr 25, 2023
Merged

[Cloud Posture] [Vulnerability Management] Add beta tooltip info (findings page) #155607

merged 1 commit into from
Apr 25, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Apr 24, 2023 •
edited
Loading

What does this PR do?

This PR adds a tooltip for the BETA badge in the Security > Findings > Vulnerabilities Tab.

Issue References

#155171

Video/Screenshot Demo

ELS-88-.Demo.mp4

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

@gitstart @KlingerMatheus
feat: [Cloud Posture] [Vulnerability Management] Add beta tooltip inf…
a2ac0fa 
…o (findings page)

Co-authored-by: KlingerMatheus <[email protected]>
Co-authored-by: gitstart_bot <[email protected]>
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@gitstart gitstart changed the title ELS-88 - [Cloud Posture] [Vulnerability Management] Add beta tooltip info (findings page) [Cloud Posture] [Vulnerability Management] Add beta tooltip info (findings page) Apr 25, 2023
@gitstart gitstart marked this pull request as ready for review April 25, 2023 11:15
@gitstart gitstart requested a review from a team as a code owner April 25, 2023 11:15
@kfirpeled kfirpeled linked an issue Apr 25, 2023 that may be closed by this pull request
[Cloud Posture] [Vulnerability Management] Add beta tooltip info (findings page) #155171
Closed
1 task
@kfirpeled kfirpeled added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related labels Apr 25, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

kfirpeled
kfirpeled reviewed Apr 25, 2023
View reviewed changes
x-pack/plugins/cloud_security_posture/public/pages/findings/findings.tsx
@@ -59,6 +59,13 @@ export const Findings = () => {
display: block;
`}
label="Beta"
tooltipContent={
<FormattedMessage
id="xpack.csp.findings.betaLabel"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Omolola-Akinleye can you double check the id is according to the i18n standards

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kfirpeled This Id correctly adheres to i18n standard and passes the translations check.

@kfirpeled
Copy link
Contributor

Buildkite, test this

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #19 / spaces api without security _update_objects_spaces multi-part tests in the default space "before all" hook for "should return 200 {objects: [alias_delete_inclusive], spacesToAdd: [], spacesToRemove: [space_2]}"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 190.3KB 190.7KB +420.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 395 398 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 475 478 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kfirpeled kfirpeled enabled auto-merge (squash) April 25, 2023 21:36
@kfirpeled
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

kfirpeled
kfirpeled approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfirpeled kfirpeled merged commit 90eee76 into elastic:main Apr 25, 2023
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Omolola-Akinleye Omolola-Akinleye Omolola-Akinleye left review comments

@kfirpeled kfirpeled kfirpeled approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting 💝community release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud Posture] [Vulnerability Management] Add beta tooltip info (findings page)
6 participants
@gitstart @kibanamachine @elasticmachine @kfirpeled @kibana-ci @Omolola-Akinleye