Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Account for missing url value #155828

Merged
merged 5 commits into from
Apr 26, 2023
Merged

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Apr 26, 2023

Summary

Fixes #153811

Show unavailble label in missing url

image

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels Apr 26, 2023
@shahzad31 shahzad31 marked this pull request as ready for review April 26, 2023 09:54
@shahzad31 shahzad31 requested a review from a team as a code owner April 26, 2023 09:54
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.2MB 1.2MB +88.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked against main and the fix is good.

Screen Shot 2023-04-26 at 1 06 00 PM

Screen Shot 2023-04-26 at 1 12 26 PM

@shahzad31 shahzad31 merged commit fa48918 into elastic:main Apr 26, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 26, 2023
@shahzad31 shahzad31 deleted the missing-url branch April 26, 2023 19:03
@shahzad31 shahzad31 removed the backport:skip This commit does not require backporting label Apr 26, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 26, 2023
@shahzad31 shahzad31 added v8.9.0 auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This commit does not require backporting labels Apr 26, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.9 The branch "8.9" does not exist

Manual backport

To create the backport manually run:

node scripts/backport --pr 155828

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Apr 27, 2023
@shahzad31
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

shahzad31 added a commit that referenced this pull request Apr 28, 2023
# Backport

This will backport the following commits from `main` to `8.8`:
- [[Synthetics] Account for missing url value
(#155828)](#155828)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-26T19:03:08Z","message":"[Synthetics]
Account for missing url value
(#155828)","sha":"fa4891847aa1e4ae187b98b2b43bb21366c9fb3a","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","auto-backport","v8.8.0","v8.9.0"],"number":155828,"url":"https://github.com/elastic/kibana/pull/155828","mergeCommit":{"message":"[Synthetics]
Account for missing url value
(#155828)","sha":"fa4891847aa1e4ae187b98b2b43bb21366c9fb3a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155828","number":155828,"mergeCommit":{"message":"[Synthetics]
Account for missing url value
(#155828)","sha":"fa4891847aa1e4ae187b98b2b43bb21366c9fb3a"}},{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthetics] Monitor details - URL field in monitor details card looks broken when url is unavailable
6 participants