Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react-ace, react-addons-test-utils, and pui tooltip dependencies #15944

Merged
merged 3 commits into from
Jan 10, 2018
Merged

Update react-ace, react-addons-test-utils, and pui tooltip dependencies #15944

merged 3 commits into from
Jan 10, 2018

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Jan 9, 2018 •
edited
Loading

Looks like the react-addons-test-utils dependency isn't in use.

rhoboat
rhoboat approved these changes Jan 9, 2018
View reviewed changes
Copy link

@rhoboat rhoboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjcenizal cjcenizal changed the title Update react-ace and react-addons-test-utils dependencies Update react-ace, react-addons-test-utils, and pui tooltip dependencies Jan 9, 2018
@cjcenizal
Copy link
Contributor Author

jenkins, test this

nreese
nreese approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjcenizal cjcenizal merged commit 1f6ea3a into elastic:master Jan 10, 2018
@cjcenizal cjcenizal deleted the upgrade/react-ace branch January 10, 2018 00:58
@cjcenizal cjcenizal added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v6.2.0 labels Jan 10, 2018
@cjcenizal cjcenizal mentioned this pull request Jan 10, 2018
Merged
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jan 10, 2018
@cjcenizal
Update react-ace, react-addons-test-utils, and pui tooltip dependenci…
6cacb63 
…es (elastic#15944)

* Upgrade react-ace to 5.5.0 for compatibility with react 16.0.0.
* Remove unused react-addons-test-utils dependency.
* Replace pui tooltip dependencies with pivotal-ui dependency.
cjcenizal added a commit that referenced this pull request Jan 10, 2018
@cjcenizal
Update react-ace, react-addons-test-utils, and pui tooltip dependenci…
1dfe3f9 
…es (#15944) (#15946)

* Upgrade react-ace to 5.5.0 for compatibility with react 16.0.0.
* Remove unused react-addons-test-utils dependency.
* Replace pui tooltip dependencies with pivotal-ui dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@rhoboat rhoboat rhoboat approved these changes

Assignees
No one assigned
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.2.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjcenizal @nreese @rhoboat