[8.9] [Security Solution] Set immutable param to true when updating prebuilt rules (#161331) #161455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t rules (elastic#161331) Fixes: elastic#161305 ## Summary - Passes a new `immutable` params to the `upgradeRule` method that is used when upgrading rules. - Looks like we had a longstanding bug here in which rule updates of rule types that changed the type of the rule were overwriting the `immutable` prop to `false`. (Actually, those rules were deleted and recreated with `immutable: false`) - This was causing the `fetchAllInstalledRules` method of our `ruleObjectsClient` NOT to retrieve these rules when they were already installed. - Since our installation `_review` and `_perform` endpoint depends on this client, these rules that had had their types updated were being incorrectly listed as available for installation. ## Testing Repeat testing steps laid out in: elastic#161305 Rules shouldn't be duplicated. ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 61fa0f5)
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @jpdjere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.9:Questions ?
Please refer to the Backport tool documentation