Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adds a11y tests for categorization and recognizer job wizards #162126

Merged
merged 2 commits into from
Jul 19, 2023
Merged

[ML] Adds a11y tests for categorization and recognizer job wizards #162126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47b7cb0
[ML] Adds a11y tests for categorization and recognizer job wizards
peteharverson Jul 18, 2023
7342cce
[ML] Remove unused interface
peteharverson Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion x-pack/plugins/ml/public/application/jobs/new_job/recognize/components/job_settings_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ export const JobSettingsForm: FC<JobSettingsFormProps> = ({
value={jobPrefix}
onChange={({ target: { value } }) => setJobPrefix(value)}
isInvalid={!!validationResult.jobPrefix}
data-test-subj="mlJobRecognizerWizardInputJobIdPrefix"
/>
</EuiFormRow>
</EuiDescribedFormGroup>
Expand Down Expand Up @@ -210,6 +211,7 @@ export const JobSettingsForm: FC<JobSettingsFormProps> = ({
/>
}
paddingSize="l"
data-test-subj="mlJobWizardToggleAdvancedSection"
>
<EuiDescribedFormGroup
title={
Expand All @@ -227,7 +229,10 @@ export const JobSettingsForm: FC<JobSettingsFormProps> = ({
/>
}
>
<EuiFormRow describedByIds={['ml_aria_label_new_job_dedicated_index']}>
<EuiFormRow
describedByIds={['ml_aria_label_new_job_dedicated_index']}
data-test-subj="mlJobWizardAdvancedSection"
>
<EuiSwitch
id="useDedicatedIndex"
name="useDedicatedIndex"
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/ml/public/application/jobs/new_job/recognize/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ export const Page: FC<PageProps> = ({ moduleId, existingGroupIds }) => {

{jobsAwaitingNodeCount > 0 && <JobsAwaitingNodeWarning jobCount={jobsAwaitingNodeCount} />}

<EuiFlexGroup wrap={true} gutterSize="m">
<EuiFlexGroup wrap={true} gutterSize="m" data-test-subj="mlPageJobWizard recognizer">
<EuiFlexItem grow={1}>
<EuiPanel grow={false} hasShadow={false} hasBorder>
<EuiTitle size="s">
Expand Down
494 changes: 1 addition & 493 deletions x-pack/test/accessibility/apps/ml.ts
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading