Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion][Storybook] Move EUI utilities cache to after all other styles #162855

Merged
merged 6 commits into from
Aug 1, 2023

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Aug 1, 2023

Summary

I missed my opportunity to leave this comment in #162757 before it merged 😅

EUI utilities should come after all other styles for CSS specificity order.

Checklist

N/A - internal infra change

- in terms of specificity order, utilities should come last
@cee-chen cee-chen requested a review from a team as a code owner August 1, 2023 00:19
@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes v8.10.0 ci:build-storybooks labels Aug 1, 2023
@cee-chen cee-chen enabled auto-merge (squash) August 1, 2023 00:20
@cee-chen cee-chen changed the title [Emotion] Move EUI utilities cache to after all other styles [Emotion][Storybook] Move EUI utilities cache to after all other styles Aug 1, 2023
@cee-chen
Copy link
Member Author

cee-chen commented Aug 1, 2023

@elasticmachine merge upstream

@cee-chen
Copy link
Member Author

cee-chen commented Aug 1, 2023

@elasticmachine merge upstream

@cee-chen
Copy link
Member Author

cee-chen commented Aug 1, 2023

@elasticmachine merge upstream

@cee-chen
Copy link
Member Author

cee-chen commented Aug 1, 2023

@elasticmachine merge upstream

@cee-chen
Copy link
Member Author

cee-chen commented Aug 1, 2023

@elasticmachine merge upstream

@cee-chen cee-chen merged commit ad33d7a into elastic:main Aug 1, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen deleted the eui-utilities-cache branch August 1, 2023 16:19
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 1, 2023
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
…#162855)

## Summary

I missed my opportunity to leave this comment in
elastic#162757 before it merged 😅

EUI utilities should come after all other styles for CSS specificity
order.

### Checklist

N/A - internal infra change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:build-storybooks release_note:skip Skip the PR/issue when compiling release notes v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants