-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emotion][Storybook] Move EUI utilities cache to after all other styles #162855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in terms of specificity order, utilities should come last
cee-chen
added
release_note:skip
Skip the PR/issue when compiling release notes
v8.10.0
ci:build-storybooks
labels
Aug 1, 2023
cee-chen
changed the title
[Emotion] Move EUI utilities cache to after all other styles
[Emotion][Storybook] Move EUI utilities cache to after all other styles
Aug 1, 2023
@elasticmachine merge upstream |
@elasticmachine merge upstream |
jbudz
approved these changes
Aug 1, 2023
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…#162855) ## Summary I missed my opportunity to leave this comment in elastic#162757 before it merged 😅 EUI utilities should come after all other styles for CSS specificity order. ### Checklist N/A - internal infra change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
ci:build-storybooks
release_note:skip
Skip the PR/issue when compiling release notes
v8.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I missed my opportunity to leave this comment in #162757 before it merged 😅
EUI utilities should come after all other styles for CSS specificity order.
Checklist
N/A - internal infra change