[Cloud Security]Added Beta tag + improvements for CIS GCP #163663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o cis-gcp-cloud-shell
…o make it easier when refactoring later
animehart
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
opauloh
requested changes
Aug 11, 2023
Comment on lines
61
to
63
| flexGrow: 1, | ||
| /* Set Maximum width ONLY for Integration type buttons, we know this because only Integration Type has icons */ | ||
| ...(option.icon && { maxWidth: `calc(${euiTheme.size.xxs} * 115)` }), |
There was a problem hiding this comment.
we can also use the flex CSS property to achieve that:
style: {
flex: '1 1 0',
},for context, flex: '1 1 0' is a shorthand representation of these three values in the order of flex-grow, flex-shrink, and flex-basis.
So, flex: '1 1 0' means that the flex item will grow and shrink proportionally with other items with an initial size of zero, making all of the elements achieve the same width.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
maxcold
reviewed
Aug 11, 2023
| @@ -123,3 +129,126 @@ describe('getMaxPackageName', () => { | |||
| expect(result).toBe('kspm-1'); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('getCspmCloudShellDefaultValue', () => { | |||
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Aug 14, 2023
…3663) ## Summary - Added Beta tag for GCP option on CSPM - Fix a bug where setup_access is stuck on google_cloud_shell ( This bug occur when user clicks on Manual option, click the start of Project ID name, and then click google cloud shell option again) - Added unit test for getCspmCloudShellDefaultValue to help with refactor later <img width="950" alt="Screenshot 2023-08-10 at 2 02 46 PM" src="https://github.com/elastic/kibana/assets/8703149/ccd45ed1-8b6c-4631-8a01-22d35d1b62aa">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary