Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Use stacked area chart for CPU usage breakdown #165828

Merged
merged 3 commits into from
Sep 6, 2023
Merged

[Infra UI] Use stacked area chart for CPU usage breakdown #165828

merged 3 commits into from
Sep 6, 2023

Conversation

mykolaharmash
Copy link
Contributor

@mykolaharmash mykolaharmash commented Sep 6, 2023 •
edited by kibanamachine
Loading

Closes #165807

Summary

Converts CPU usage breakdown chart from area_percentage_stacked to area_stacked

@mykolaharmash mykolaharmash added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.11.0 labels Sep 6, 2023
@mykolaharmash mykolaharmash requested a review from a team as a code owner September 6, 2023 10:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mykolaharmash
Copy link
Contributor Author

@elasticmachine merge upstream

@jennypavlova jennypavlova self-requested a review September 6, 2023 11:36
jennypavlova
jennypavlova approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the chart LGTM 🚀
image

@mykolaharmash
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 6, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Observability Tests / serverless observability UI Observability Log Explorer Columns selection initialization and update "after all" hook in "Columns selection initialization and update"
  • [job] [logs] Serverless Observability Tests / serverless observability UI Observability Log Explorer Columns selection initialization and update "before all" hook in "Columns selection initialization and update"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.0MB 2.0MB -11.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mykolaharmash mykolaharmash merged commit 28aafed into elastic:main Sep 6, 2023
24 of 25 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.10 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.10:
- [Actions] Adjust axios payload for APIs that do not want data sent (#165756)

Manual backport

To create the backport manually run:

node scripts/backport --pr 165828

Questions ?

Please refer to the Backport tool documentation

bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Sep 19, 2023
@mykolaharmash @kibanamachine @bryce-b
[Infra UI] Use stacked area chart for CPU usage breakdown (elastic#16…
6173f6a 
…5828)

Closes elastic#165807 

## Summary

Converts CPU usage breakdown chart from `area_percentage_stacked` to
`area_stacked`

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 18, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 165828 locally

@smith smith added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels May 18, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennypavlova jennypavlova jennypavlova approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra UI] Convert CPU Usage breakdown to stacked area chart (asset detail)
7 participants
@mykolaharmash @elasticmachine @apmmachine @kibana-ci @kibanamachine @jennypavlova @smith