Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Remove Kui style sheet import #167054

Merged
merged 2 commits into from
Sep 25, 2023
Merged

[Canvas] Remove Kui style sheet import #167054

merged 2 commits into from
Sep 25, 2023

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Sep 22, 2023 •
edited
Loading

Summary

Part of #46410

I couldn't find any usages of any of the kui* classes in the Canvas shareable runtime, so I've just removed the import of the stylesheet.

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@ThomThomson ThomThomson added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Canvas labels Sep 25, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #13 / serverless examples UI Discover customization examples Customizations "before all" hook for "Top nav"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson marked this pull request as ready for review September 25, 2023 17:13
@ThomThomson ThomThomson requested a review from a team as a code owner September 25, 2023 17:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson mentioned this pull request Sep 25, 2023
Closed
Heenawter
Heenawter approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight forward - LGTM 👍

@ThomThomson ThomThomson merged commit f23f2f4 into elastic:main Sep 25, 2023
31 checks passed
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ThomThomson @kibana-ci @elasticmachine @Heenawter @kibanamachine