Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saved query update test #173576

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Conversation

lukasolson
Copy link
Member

@lukasolson lukasolson commented Dec 18, 2023

Summary

Fixes #173094.

Relying on the text from the toast notification was problematic because sometimes the toast would already have disappeared by the time the check was happening. Instead, this updates the test to refresh and check the saved query list for the updated saved query.

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4750

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@lukasolson lukasolson self-assigned this Dec 18, 2023
@lukasolson lukasolson marked this pull request as ready for review January 3, 2024 23:05
@lukasolson lukasolson requested a review from a team as a code owner January 3, 2024 23:05
@lukasolson lukasolson added the Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) label Jan 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lukasolson lukasolson added v8.13.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 3, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lukasolson lukasolson merged commit 9cb830f into elastic:main Jan 4, 2024
26 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v8.13.0
Projects
None yet
5 participants